Skip to content

Fix swig check setup#861

Closed
jvkersch wants to merge 1 commit into
masterfrom
fix-swig-check-setup
Closed

Fix swig check setup#861
jvkersch wants to merge 1 commit into
masterfrom
fix-swig-check-setup

Conversation

@jvkersch
Copy link
Copy Markdown
Contributor

@jvkersch jvkersch commented Jun 18, 2021

Follow-up from #839

Removes the check for Swig (thus undoing the changes from #811). I originally wanted to remove just the version check and leave the check for Swig being found in the path, but I figured that Swig not being installed would be flagged pretty soon anyway when the extension modules are compared.

@jvkersch jvkersch force-pushed the fix-swig-check-setup branch from 6756e65 to c8d832b Compare June 18, 2021 12:47
aaronayres35
aaronayres35 approved these changes Jun 18, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@aaronayres35 aaronayres35 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

In a fresh edm env, running pip install -e . on master gives:

Details 
$ pip install -e .
Obtaining file:///Users/aayres/Desktop/enable
  Installing build dependencies ... done
  Getting requirements to build wheel ... error
  ERROR: Command errored out with exit status 1:
   command: /Users/aayres/.edm/envs/test-enable/bin/python3 /Users/aayres/.edm/envs/test-enable/lib/python3.6/site-packages/pip/_vendor/pep517/_in_process.py get_requires_for_build_wheel /var/folders/j9/ps8s26f91_1_lgf7mtd4smyr0000gn/T/tmpv91pnjnn
       cwd: /Users/aayres/Desktop/enable
  Complete output (29 lines):
  Traceback (most recent call last):
    File "setup.py", line 441, in verify_swig_version
      with subprocess.Popen(cmd, **opts) as proc:
    File "/Users/aayres/.edm/envs/test-enable/lib/python3.6/subprocess.py", line 729, in __init__
      restore_signals, start_new_session)
    File "/Users/aayres/.edm/envs/test-enable/lib/python3.6/subprocess.py", line 1364, in _execute_child
      raise child_exception_type(errno_num, err_msg, err_filename)
  FileNotFoundError: [Errno 2] No such file or directory: 'swig': 'swig'
  
  During handling of the above exception, another exception occurred:
  
  Traceback (most recent call last):
    File "/Users/aayres/.edm/envs/test-enable/lib/python3.6/site-packages/pip/_vendor/pep517/_in_process.py", line 257, in <module>
      main()
    File "/Users/aayres/.edm/envs/test-enable/lib/python3.6/site-packages/pip/_vendor/pep517/_in_process.py", line 240, in main
      json_out['return_val'] = hook(**hook_input['kwargs'])
    File "/Users/aayres/.edm/envs/test-enable/lib/python3.6/site-packages/pip/_vendor/pep517/_in_process.py", line 91, in get_requires_for_build_wheel
      return hook(config_settings)
    File "/private/var/folders/j9/ps8s26f91_1_lgf7mtd4smyr0000gn/T/pip-build-env-36srkj8s/overlay/lib/python3.6/site-packages/setuptools/build_meta.py", line 155, in get_requires_for_build_wheel
      config_settings, requirements=['wheel'])
    File "/private/var/folders/j9/ps8s26f91_1_lgf7mtd4smyr0000gn/T/pip-build-env-36srkj8s/overlay/lib/python3.6/site-packages/setuptools/build_meta.py", line 135, in _get_build_requires
      self.run_setup()
    File "/private/var/folders/j9/ps8s26f91_1_lgf7mtd4smyr0000gn/T/pip-build-env-36srkj8s/overlay/lib/python3.6/site-packages/setuptools/build_meta.py", line 150, in run_setup
      exec(compile(code, __file__, 'exec'), locals())
    File "setup.py", line 454, in <module>
      verify_swig_version()
    File "setup.py", line 450, in verify_swig_version
      raise Exception(msg)
  Exception: SWIG is a required build dependency of Enable. Furthermore, there is currently a known issue with SWIG 4.0, see enthought/enable#360. Please install SWIG 3.0.x (see http://www.swig.org/).
  ----------------------------------------
ERROR: Command errored out with exit status 1: /Users/aayres/.edm/envs/test-enable/bin/python3 /Users/aayres/.edm/envs/test-enable/lib/python3.6/site-packages/pip/_vendor/pep517/_in_process.py get_requires_for_build_wheel /var/folders/j9/ps8s26f91_1_lgf7mtd4smyr0000gn/T/tmpv91pnjnn Check the logs for full command output.

Whereas on this branch you see the long-winded but informative traceback:

Details 
$ pip install -e .
Obtaining file:///Users/aayres/Desktop/enable
  Installing build dependencies ... done
  Getting requirements to build wheel ... done
    Preparing wheel metadata ... done
Collecting traits>=6.2.0
  Using cached traits-6.2.0-cp36-cp36m-macosx_10_14_x86_64.whl (5.0 MB)
Collecting traitsui
  Using cached traitsui-7.2.1.tar.gz (6.7 MB)
Collecting numpy
  Using cached numpy-1.19.5-cp36-cp36m-macosx_10_9_x86_64.whl (15.6 MB)
Processing /Users/aayres/Library/Caches/pip/wheels/c9/24/5a/1231d8847ac0ff839cc5b7810612b851318a6d2c66a891c031/pyface-7.3.0-py3-none-any.whl
Collecting fonttools
  Using cached fonttools-4.24.4-py3-none-any.whl (854 kB)
Collecting pillow
  Using cached Pillow-8.2.0-cp36-cp36m-macosx_10_10_x86_64.whl (2.8 MB)
Collecting importlib-metadata
  Using cached importlib_metadata-4.5.0-py3-none-any.whl (17 kB)
Collecting importlib-resources>=1.1.0
  Using cached importlib_resources-5.1.4-py3-none-any.whl (26 kB)
Collecting zipp>=0.5
  Using cached zipp-3.4.1-py3-none-any.whl (5.2 kB)
Collecting typing-extensions>=3.6.4; python_version < "3.8"
  Using cached typing_extensions-3.10.0.0-py3-none-any.whl (26 kB)
Installing collected packages: traits, zipp, typing-extensions, importlib-metadata, importlib-resources, pyface, traitsui, numpy, fonttools, pillow, enable
    Running setup.py install for traitsui ... done
  Running setup.py develop for enable
    ERROR: Command errored out with exit status 1:
     command: /Users/aayres/.edm/envs/test-enable/bin/python3 -c 'import sys, setuptools, tokenize; sys.argv[0] = '"'"'/Users/aayres/Desktop/enable/setup.py'"'"'; __file__='"'"'/Users/aayres/Desktop/enable/setup.py'"'"';f=getattr(tokenize, '"'"'open'"'"', open)(__file__);code=f.read().replace('"'"'\r\n'"'"', '"'"'\n'"'"');f.close();exec(compile(code, __file__, '"'"'exec'"'"'))' develop --no-deps
         cwd: /Users/aayres/Desktop/enable/
    Complete output (353 lines):
    running develop
    running egg_info
    writing enable.egg-info/PKG-INFO
    writing dependency_links to enable.egg-info/dependency_links.txt
    writing entry points to enable.egg-info/entry_points.txt
    writing requirements to enable.egg-info/requires.txt
    writing top-level names to enable.egg-info/top_level.txt
    reading manifest file 'enable.egg-info/SOURCES.txt'
    reading manifest template 'MANIFEST.in'
    warning: no files found matching 'docs/kiva/agg/notes'
    adding license file 'LICENSE.txt'
    writing manifest file 'enable.egg-info/SOURCES.txt'
    running build_ext
    skipping 'kiva/_cython_speedups.cpp' Cython extension (up-to-date)
    cythoning kiva/_marker_renderer.pyx to kiva/_marker_renderer.cpp
    cythoning kiva/quartz/ABCGI.pyx to kiva/quartz/ABCGI.c
    cythoning kiva/quartz/CTFont.pyx to kiva/quartz/CTFont.c
    /private/var/folders/j9/ps8s26f91_1_lgf7mtd4smyr0000gn/T/pip-build-env-d8qeockt/overlay/lib/python3.6/site-packages/Cython/Compiler/Main.py:369: FutureWarning: Cython directive 'language_level' not set, using 2 for now (Py2). This will change in a later release! File: /Users/aayres/Desktop/enable/kiva/_marker_renderer.pxd
      tree = Parsing.p_module(s, pxd, full_module_name)
    /private/var/folders/j9/ps8s26f91_1_lgf7mtd4smyr0000gn/T/pip-build-env-d8qeockt/overlay/lib/python3.6/site-packages/Cython/Compiler/Main.py:369: FutureWarning: Cython directive 'language_level' not set, using 2 for now (Py2). This will change in a later release! File: /Users/aayres/Desktop/enable/kiva/quartz/ABCGI.pyx
      tree = Parsing.p_module(s, pxd, full_module_name)
    warning: kiva/quartz/CoreFoundation.pxi:17:4: 'CFStringEncoding' redeclared
    warning: kiva/quartz/CoreFoundation.pxi:57:4: 'CFURLPathStyle' redeclared
    warning: kiva/quartz/CoreFoundation.pxi:165:4: 'CFNumberType_' redeclared
    warning: kiva/quartz/CoreGraphics.pxi:36:4: 'CGBlendMode' redeclared
    warning: kiva/quartz/CoreGraphics.pxi:54:4: 'CGLineCap' redeclared
    warning: kiva/quartz/CoreGraphics.pxi:59:4: 'CGLineJoin' redeclared
    warning: kiva/quartz/CoreGraphics.pxi:64:4: 'CGPathDrawingMode' redeclared
    warning: kiva/quartz/CoreGraphics.pxi:71:4: 'CGRectEdge' redeclared
    warning: kiva/quartz/CoreGraphics.pxi:161:4: 'CGColorRenderingIntent' redeclared
    warning: kiva/quartz/CoreGraphics.pxi:173:4: 'FakedEnums' redeclared
    warning: kiva/quartz/CoreGraphics.pxi:240:4: 'CGTextDrawingMode' redeclared
    warning: kiva/quartz/CoreGraphics.pxi:250:4: 'CGTextEncoding' redeclared
    warning: kiva/quartz/CoreGraphics.pxi:334:4: 'CGImageAlphaInfo' redeclared
    warning: kiva/quartz/CoreGraphics.pxi:344:4: 'CGInterpolationQuality' redeclared
    warning: kiva/quartz/CoreGraphics.pxi:451:4: 'CGPathElementType' redeclared
    warning: kiva/quartz/CoreFoundation.pxi:12:4: 'OSStatus' redeclared
    warning: kiva/quartz/CoreFoundation.pxi:15:8: 'noErr' redeclared
    warning: kiva/quartz/CoreFoundation.pxi:18:8: 'kCFStringEncodingMacRoman' redeclared
    warning: kiva/quartz/CoreFoundation.pxi:19:8: 'kCFStringEncodingWindowsLatin1' redeclared
    warning: kiva/quartz/CoreFoundation.pxi:20:8: 'kCFStringEncodingISOLatin1' redeclared
    warning: kiva/quartz/CoreFoundation.pxi:21:8: 'kCFStringEncodingNextStepLatin' redeclared
    warning: kiva/quartz/CoreFoundation.pxi:22:8: 'kCFStringEncodingASCII' redeclared
    warning: kiva/quartz/CoreFoundation.pxi:23:8: 'kCFStringEncodingUnicode' redeclared
    warning: kiva/quartz/CoreFoundation.pxi:24:8: 'kCFStringEncodingUTF8' redeclared
    warning: kiva/quartz/CoreFoundation.pxi:25:8: 'kCFStringEncodingNonLossyASCII' redeclared
    warning: kiva/quartz/CoreFoundation.pxi:27:4: 'UInt8' redeclared
    warning: kiva/quartz/CoreFoundation.pxi:28:4: 'UniChar' redeclared
    warning: kiva/quartz/CoreFoundation.pxi:29:4: 'bool' redeclared
    warning: kiva/quartz/CoreFoundation.pxi:30:4: 'Boolean' redeclared
    warning: kiva/quartz/CoreFoundation.pxi:32:4: 'CFTypeRef' redeclared
    warning: kiva/quartz/CoreFoundation.pxi:33:4: 'CFTypeID' redeclared
    warning: kiva/quartz/CoreFoundation.pxi:37:4: 'CFStringRef' redeclared
    warning: kiva/quartz/CoreFoundation.pxi:39:4: 'CFIndex' redeclared
    warning: kiva/quartz/CoreFoundation.pxi:40:4: 'CFNumberType' redeclared
    warning: kiva/quartz/CoreFoundation.pxi:42:4: 'CFHashCode' redeclared
    warning: kiva/quartz/CoreFoundation.pxi:58:8: 'kCFURLPOSIXPathStyle' redeclared
    warning: kiva/quartz/CoreFoundation.pxi:59:8: 'kCFURLHFSPathStyle' redeclared
    warning: kiva/quartz/CoreFoundation.pxi:60:8: 'kCFURLWindowsPathStyle' redeclared
    warning: kiva/quartz/CoreFoundation.pxi:62:4: 'CFURLRef' redeclared
    warning: kiva/quartz/CoreFoundation.pxi:76:26: 'kCFTypeArrayCallBacks' redeclared
    warning: kiva/quartz/CoreFoundation.pxi:78:4: 'CFArrayRef' redeclared
    warning: kiva/quartz/CoreFoundation.pxi:79:4: 'CFMutableArrayRef' redeclared
    warning: kiva/quartz/CoreFoundation.pxi:120:4: 'CFDictionaryRef' redeclared
    warning: kiva/quartz/CoreFoundation.pxi:121:4: 'CFMutableDictionaryRef' redeclared
    warning: kiva/quartz/CoreFoundation.pxi:138:34: 'kCFTypeDictionaryKeyCallBacks' redeclared
    warning: kiva/quartz/CoreFoundation.pxi:139:36: 'kCFTypeDictionaryValueCallBacks' redeclared
    warning: kiva/quartz/CoreFoundation.pxi:151:4: 'CFAttributedStringRef' redeclared
    warning: kiva/quartz/CoreFoundation.pxi:152:4: 'CFMutableAttributedStringRef' redeclared
    warning: kiva/quartz/CoreFoundation.pxi:163:4: 'CFNumberRef' redeclared
    warning: kiva/quartz/CoreFoundation.pxi:166:8: 'kCFNumberSInt8Type' redeclared
    warning: kiva/quartz/CoreFoundation.pxi:167:8: 'kCFNumberSInt16Type' redeclared
    warning: kiva/quartz/CoreFoundation.pxi:168:8: 'kCFNumberSInt32Type' redeclared
    warning: kiva/quartz/CoreFoundation.pxi:169:8: 'kCFNumberSInt64Type' redeclared
    warning: kiva/quartz/CoreFoundation.pxi:170:8: 'kCFNumberFloat32Type' redeclared
    warning: kiva/quartz/CoreFoundation.pxi:171:8: 'kCFNumberFloat64Type' redeclared
    warning: kiva/quartz/CoreFoundation.pxi:172:8: 'kCFNumberCharType' redeclared
    warning: kiva/quartz/CoreFoundation.pxi:173:8: 'kCFNumberShortType' redeclared
    warning: kiva/quartz/CoreFoundation.pxi:174:8: 'kCFNumberIntType' redeclared
    warning: kiva/quartz/CoreFoundation.pxi:175:8: 'kCFNumberLongType' redeclared
    warning: kiva/quartz/CoreFoundation.pxi:176:8: 'kCFNumberLongLongType' redeclared
    warning: kiva/quartz/CoreFoundation.pxi:177:8: 'kCFNumberFloatType' redeclared
    warning: kiva/quartz/CoreFoundation.pxi:178:8: 'kCFNumberDoubleType' redeclared
    warning: kiva/quartz/CoreFoundation.pxi:179:8: 'kCFNumberCFIndexType' redeclared
    warning: kiva/quartz/CoreGraphics.pxi:12:4: 'CGContextRef' redeclared
    warning: kiva/quartz/CoreGraphics.pxi:14:4: 'CGFloat' redeclared
    warning: kiva/quartz/CoreGraphics.pxi:37:8: 'kCGBlendModeNormal' redeclared
    warning: kiva/quartz/CoreGraphics.pxi:38:8: 'kCGBlendModeMultiply' redeclared
    warning: kiva/quartz/CoreGraphics.pxi:39:8: 'kCGBlendModeScreen' redeclared
    warning: kiva/quartz/CoreGraphics.pxi:40:8: 'kCGBlendModeOverlay' redeclared
    warning: kiva/quartz/CoreGraphics.pxi:41:8: 'kCGBlendModeDarken' redeclared
    warning: kiva/quartz/CoreGraphics.pxi:42:8: 'kCGBlendModeLighten' redeclared
    warning: kiva/quartz/CoreGraphics.pxi:43:8: 'kCGBlendModeColorDodge' redeclared
    warning: kiva/quartz/CoreGraphics.pxi:44:8: 'kCGBlendModeColorBurn' redeclared
    warning: kiva/quartz/CoreGraphics.pxi:45:8: 'kCGBlendModeSoftLight' redeclared
    warning: kiva/quartz/CoreGraphics.pxi:46:8: 'kCGBlendModeHardLight' redeclared
    warning: kiva/quartz/CoreGraphics.pxi:47:8: 'kCGBlendModeDifference' redeclared
    warning: kiva/quartz/CoreGraphics.pxi:48:8: 'kCGBlendModeExclusion' redeclared
    warning: kiva/quartz/CoreGraphics.pxi:49:8: 'kCGBlendModeHue' redeclared
    warning: kiva/quartz/CoreGraphics.pxi:50:8: 'kCGBlendModeSaturation' redeclared
    warning: kiva/quartz/CoreGraphics.pxi:51:8: 'kCGBlendModeColor' redeclared
    warning: kiva/quartz/CoreGraphics.pxi:52:8: 'kCGBlendModeLuminosity' redeclared
    warning: kiva/quartz/CoreGraphics.pxi:55:8: 'kCGLineCapButt' redeclared
    warning: kiva/quartz/CoreGraphics.pxi:56:8: 'kCGLineCapRound' redeclared
    warning: kiva/quartz/CoreGraphics.pxi:57:8: 'kCGLineCapSquare' redeclared
    warning: kiva/quartz/CoreGraphics.pxi:60:8: 'kCGLineJoinMiter' redeclared
    warning: kiva/quartz/CoreGraphics.pxi:61:8: 'kCGLineJoinRound' redeclared
    warning: kiva/quartz/CoreGraphics.pxi:62:8: 'kCGLineJoinBevel' redeclared
    warning: kiva/quartz/CoreGraphics.pxi:65:8: 'kCGPathFill' redeclared
    warning: kiva/quartz/CoreGraphics.pxi:66:8: 'kCGPathEOFill' redeclared
    warning: kiva/quartz/CoreGraphics.pxi:67:8: 'kCGPathStroke' redeclared
    warning: kiva/quartz/CoreGraphics.pxi:68:8: 'kCGPathFillStroke' redeclared
    warning: kiva/quartz/CoreGraphics.pxi:69:8: 'kCGPathEOFillStroke' redeclared
    warning: kiva/quartz/CoreGraphics.pxi:72:8: 'CGRectMinXEdge' redeclared
    warning: kiva/quartz/CoreGraphics.pxi:73:8: 'CGRectMinYEdge' redeclared
    warning: kiva/quartz/CoreGraphics.pxi:74:8: 'CGRectMaxXEdge' redeclared
    warning: kiva/quartz/CoreGraphics.pxi:75:8: 'CGRectMaxYEdge' redeclared
    warning: kiva/quartz/CoreGraphics.pxi:159:4: 'CGColorSpaceRef' redeclared
    warning: kiva/quartz/CoreGraphics.pxi:162:8: 'kCGRenderingIntentDefault' redeclared
    warning: kiva/quartz/CoreGraphics.pxi:163:8: 'kCGRenderingIntentAbsoluteColorimetric' redeclared
    warning: kiva/quartz/CoreGraphics.pxi:164:8: 'kCGRenderingIntentRelativeColorimetric' redeclared
    warning: kiva/quartz/CoreGraphics.pxi:165:8: 'kCGRenderingIntentPerceptual' redeclared
    warning: kiva/quartz/CoreGraphics.pxi:166:8: 'kCGRenderingIntentSaturation' redeclared
    warning: kiva/quartz/CoreGraphics.pxi:169:8: 'kCGColorSpaceUserGray' redeclared
    warning: kiva/quartz/CoreGraphics.pxi:170:8: 'kCGColorSpaceUserRGB' redeclared
    warning: kiva/quartz/CoreGraphics.pxi:171:8: 'kCGColorSpaceUserCMYK' redeclared
    warning: kiva/quartz/CoreGraphics.pxi:174:8: 'kCGColorSpaceGenericGray' redeclared
    warning: kiva/quartz/CoreGraphics.pxi:175:8: 'kCGColorSpaceGenericRGB' redeclared
    warning: kiva/quartz/CoreGraphics.pxi:176:8: 'kCGColorSpaceGenericCMYK' redeclared
    warning: kiva/quartz/CoreGraphics.pxi:186:4: 'CGColorRef' redeclared
    warning: kiva/quartz/CoreGraphics.pxi:225:4: 'CGFontRef' redeclared
    warning: kiva/quartz/CoreGraphics.pxi:226:4: 'CGFontIndex' redeclared
    warning: kiva/quartz/CoreGraphics.pxi:227:4: 'CGGlyph' redeclared
    warning: kiva/quartz/CoreGraphics.pxi:230:8: 'kCGFontIndexMax' redeclared
    warning: kiva/quartz/CoreGraphics.pxi:231:8: 'kCGFontIndexInvalid' redeclared
    warning: kiva/quartz/CoreGraphics.pxi:232:8: 'kCGGlyphMax' redeclared
    warning: kiva/quartz/CoreGraphics.pxi:241:8: 'kCGTextFill' redeclared
    warning: kiva/quartz/CoreGraphics.pxi:242:8: 'kCGTextStroke' redeclared
    warning: kiva/quartz/CoreGraphics.pxi:243:8: 'kCGTextFillStroke' redeclared
    warning: kiva/quartz/CoreGraphics.pxi:244:8: 'kCGTextInvisible' redeclared
    warning: kiva/quartz/CoreGraphics.pxi:245:8: 'kCGTextFillClip' redeclared
    warning: kiva/quartz/CoreGraphics.pxi:246:8: 'kCGTextStrokeClip' redeclared
    warning: kiva/quartz/CoreGraphics.pxi:247:8: 'kCGTextFillStrokeClip' redeclared
    warning: kiva/quartz/CoreGraphics.pxi:248:8: 'kCGTextClip' redeclared
    warning: kiva/quartz/CoreGraphics.pxi:251:8: 'kCGEncodingFontSpecific' redeclared
    warning: kiva/quartz/CoreGraphics.pxi:252:8: 'kCGEncodingMacRoman' redeclared
    warning: kiva/quartz/CoreGraphics.pxi:273:4: 'CGDataProviderRef' redeclared
    warning: kiva/quartz/CoreGraphics.pxi:314:22: 'CGAffineTransformIdentity' redeclared
    warning: kiva/quartz/CoreGraphics.pxi:332:4: 'CGImageRef' redeclared
    warning: kiva/quartz/CoreGraphics.pxi:335:8: 'kCGImageAlphaNone' redeclared
    warning: kiva/quartz/CoreGraphics.pxi:336:8: 'kCGImageAlphaPremultipliedLast' redeclared
    warning: kiva/quartz/CoreGraphics.pxi:337:8: 'kCGImageAlphaPremultipliedFirst' redeclared
    warning: kiva/quartz/CoreGraphics.pxi:338:8: 'kCGImageAlphaLast' redeclared
    warning: kiva/quartz/CoreGraphics.pxi:339:8: 'kCGImageAlphaFirst' redeclared
    warning: kiva/quartz/CoreGraphics.pxi:340:8: 'kCGImageAlphaNoneSkipLast' redeclared
    warning: kiva/quartz/CoreGraphics.pxi:341:8: 'kCGImageAlphaNoneSkipFirst' redeclared
    warning: kiva/quartz/CoreGraphics.pxi:342:8: 'kCGImageAlphaOnly' redeclared
    warning: kiva/quartz/CoreGraphics.pxi:345:8: 'kCGInterpolationDefault' redeclared
    warning: kiva/quartz/CoreGraphics.pxi:346:8: 'kCGInterpolationNone' redeclared
    warning: kiva/quartz/CoreGraphics.pxi:347:8: 'kCGInterpolationLow' redeclared
    warning: kiva/quartz/CoreGraphics.pxi:348:8: 'kCGInterpolationHigh' redeclared
    warning: kiva/quartz/CoreGraphics.pxi:382:4: 'CGPDFDocumentRef' redeclared
    warning: kiva/quartz/CoreGraphics.pxi:418:4: 'CGMutablePathRef' redeclared
    warning: kiva/quartz/CoreGraphics.pxi:419:4: 'CGPathRef' redeclared
    warning: kiva/quartz/CoreGraphics.pxi:452:8: 'kCGPathElementMoveToPoint' redeclared
    warning: kiva/quartz/CoreGraphics.pxi:453:8: 'kCGPathElementAddLineToPoint' redeclared
    warning: kiva/quartz/CoreGraphics.pxi:454:8: 'kCGPathElementAddQuadCurveToPoint' redeclared
    warning: kiva/quartz/CoreGraphics.pxi:455:8: 'kCGPathElementAddCurveToPoint' redeclared
    warning: kiva/quartz/CoreGraphics.pxi:456:8: 'kCGPathElementCloseSubpath' redeclared
    warning: kiva/quartz/CoreGraphics.pxi:462:4: 'CGPathApplierFunction' redeclared
    warning: kiva/quartz/CoreGraphics.pxi:466:4: 'CGFunctionRef' redeclared
    warning: kiva/quartz/CoreGraphics.pxi:468:4: 'CGFunctionEvaluateCallback' redeclared
    warning: kiva/quartz/CoreGraphics.pxi:470:4: 'CGFunctionReleaseInfoCallback' redeclared
    warning: kiva/quartz/CoreGraphics.pxi:483:4: 'CGShadingRef' redeclared
    warning: kiva/quartz/CoreGraphics.pxi:500:4: 'CGLayerRef' redeclared
    /private/var/folders/j9/ps8s26f91_1_lgf7mtd4smyr0000gn/T/pip-build-env-d8qeockt/overlay/lib/python3.6/site-packages/Cython/Compiler/Main.py:369: FutureWarning: Cython directive 'language_level' not set, using 2 for now (Py2). This will change in a later release! File: /Users/aayres/Desktop/enable/kiva/quartz/CTFont.pyx
      tree = Parsing.p_module(s, pxd, full_module_name)
    warning: kiva/quartz/CoreFoundation.pxi:17:4: 'CFStringEncoding' redeclared
    warning: kiva/quartz/CoreFoundation.pxi:57:4: 'CFURLPathStyle' redeclared
    warning: kiva/quartz/CoreFoundation.pxi:165:4: 'CFNumberType_' redeclared
    warning: kiva/quartz/CoreGraphics.pxi:36:4: 'CGBlendMode' redeclared
    warning: kiva/quartz/CoreGraphics.pxi:54:4: 'CGLineCap' redeclared
    warning: kiva/quartz/CoreGraphics.pxi:59:4: 'CGLineJoin' redeclared
    warning: kiva/quartz/CoreGraphics.pxi:64:4: 'CGPathDrawingMode' redeclared
    warning: kiva/quartz/CoreGraphics.pxi:71:4: 'CGRectEdge' redeclared
    warning: kiva/quartz/CoreGraphics.pxi:161:4: 'CGColorRenderingIntent' redeclared
    warning: kiva/quartz/CoreGraphics.pxi:173:4: 'FakedEnums' redeclared
    warning: kiva/quartz/CoreGraphics.pxi:240:4: 'CGTextDrawingMode' redeclared
    warning: kiva/quartz/CoreGraphics.pxi:250:4: 'CGTextEncoding' redeclared
    warning: kiva/quartz/CoreGraphics.pxi:334:4: 'CGImageAlphaInfo' redeclared
    warning: kiva/quartz/CoreGraphics.pxi:344:4: 'CGInterpolationQuality' redeclared
    warning: kiva/quartz/CoreGraphics.pxi:451:4: 'CGPathElementType' redeclared
    warning: kiva/quartz/CoreFoundation.pxi:12:4: 'OSStatus' redeclared
    warning: kiva/quartz/CoreFoundation.pxi:15:8: 'noErr' redeclared
    warning: kiva/quartz/CoreFoundation.pxi:18:8: 'kCFStringEncodingMacRoman' redeclared
    warning: kiva/quartz/CoreFoundation.pxi:19:8: 'kCFStringEncodingWindowsLatin1' redeclared
    warning: kiva/quartz/CoreFoundation.pxi:20:8: 'kCFStringEncodingISOLatin1' redeclared
    warning: kiva/quartz/CoreFoundation.pxi:21:8: 'kCFStringEncodingNextStepLatin' redeclared
    warning: kiva/quartz/CoreFoundation.pxi:22:8: 'kCFStringEncodingASCII' redeclared
    warning: kiva/quartz/CoreFoundation.pxi:23:8: 'kCFStringEncodingUnicode' redeclared
    warning: kiva/quartz/CoreFoundation.pxi:24:8: 'kCFStringEncodingUTF8' redeclared
    warning: kiva/quartz/CoreFoundation.pxi:25:8: 'kCFStringEncodingNonLossyASCII' redeclared
    warning: kiva/quartz/CoreFoundation.pxi:27:4: 'UInt8' redeclared
    warning: kiva/quartz/CoreFoundation.pxi:28:4: 'UniChar' redeclared
    warning: kiva/quartz/CoreFoundation.pxi:29:4: 'bool' redeclared
    warning: kiva/quartz/CoreFoundation.pxi:30:4: 'Boolean' redeclared
    warning: kiva/quartz/CoreFoundation.pxi:32:4: 'CFTypeRef' redeclared
    warning: kiva/quartz/CoreFoundation.pxi:33:4: 'CFTypeID' redeclared
    warning: kiva/quartz/CoreFoundation.pxi:37:4: 'CFStringRef' redeclared
    warning: kiva/quartz/CoreFoundation.pxi:39:4: 'CFIndex' redeclared
    warning: kiva/quartz/CoreFoundation.pxi:40:4: 'CFNumberType' redeclared
    warning: kiva/quartz/CoreFoundation.pxi:42:4: 'CFHashCode' redeclared
    warning: kiva/quartz/CoreFoundation.pxi:58:8: 'kCFURLPOSIXPathStyle' redeclared
    warning: kiva/quartz/CoreFoundation.pxi:59:8: 'kCFURLHFSPathStyle' redeclared
    warning: kiva/quartz/CoreFoundation.pxi:60:8: 'kCFURLWindowsPathStyle' redeclared
    warning: kiva/quartz/CoreFoundation.pxi:62:4: 'CFURLRef' redeclared
    warning: kiva/quartz/CoreFoundation.pxi:76:26: 'kCFTypeArrayCallBacks' redeclared
    warning: kiva/quartz/CoreFoundation.pxi:78:4: 'CFArrayRef' redeclared
    warning: kiva/quartz/CoreFoundation.pxi:79:4: 'CFMutableArrayRef' redeclared
    warning: kiva/quartz/CoreFoundation.pxi:120:4: 'CFDictionaryRef' redeclared
    building 'kiva._cython_speedups' extension
    creating build
    creating build/temp.macosx-10.9-x86_64-3.6
    creating build/temp.macosx-10.9-x86_64-3.6/kiva
    gcc -Wno-unused-result -Wsign-compare -Wunreachable-code -fno-common -dynamic -DNDEBUG -g -fwrapv -O3 -Wall -g -arch x86_64 -arch x86_64 -Ikiva -I/private/var/folders/j9/ps8s26f91_1_lgf7mtd4smyr0000gn/T/pip-build-env-d8qeockt/overlay/lib/python3.6/site-packages/numpy/core/include -I/Users/aayres/.edm/envs/test-enable/include/python3.6m -c kiva/_cython_speedups.cpp -o build/temp.macosx-10.9-x86_64-3.6/kiva/_cython_speedups.o
    In file included from kiva/_cython_speedups.cpp:612:
    In file included from /private/var/folders/j9/ps8s26f91_1_lgf7mtd4smyr0000gn/T/pip-build-env-d8qeockt/overlay/lib/python3.6/site-packages/numpy/core/include/numpy/arrayobject.h:4:
    In file included from /private/var/folders/j9/ps8s26f91_1_lgf7mtd4smyr0000gn/T/pip-build-env-d8qeockt/overlay/lib/python3.6/site-packages/numpy/core/include/numpy/ndarrayobject.h:18:
    In file included from /private/var/folders/j9/ps8s26f91_1_lgf7mtd4smyr0000gn/T/pip-build-env-d8qeockt/overlay/lib/python3.6/site-packages/numpy/core/include/numpy/ndarraytypes.h:1809:
    /private/var/folders/j9/ps8s26f91_1_lgf7mtd4smyr0000gn/T/pip-build-env-d8qeockt/overlay/lib/python3.6/site-packages/numpy/core/include/numpy/npy_1_7_deprecated_api.h:15:2: warning: "Using deprecated NumPy API, disable it by "          "#defining NPY_NO_DEPRECATED_API NPY_1_7_API_VERSION" [-W#warnings]
    #warning "Using deprecated NumPy API, disable it by " \
     ^
    1 warning generated.
    gcc -Wno-unused-result -Wsign-compare -Wunreachable-code -fno-common -dynamic -DNDEBUG -g -fwrapv -O3 -Wall -g -arch x86_64 -arch x86_64 -Ikiva -I/private/var/folders/j9/ps8s26f91_1_lgf7mtd4smyr0000gn/T/pip-build-env-d8qeockt/overlay/lib/python3.6/site-packages/numpy/core/include -I/Users/aayres/.edm/envs/test-enable/include/python3.6m -c kiva/_hit_test.cpp -o build/temp.macosx-10.9-x86_64-3.6/kiva/_hit_test.o
    g++ -bundle -undefined dynamic_lookup -g -arch x86_64 -headerpad_max_install_names build/temp.macosx-10.9-x86_64-3.6/kiva/_cython_speedups.o build/temp.macosx-10.9-x86_64-3.6/kiva/_hit_test.o -o /Users/aayres/Desktop/enable/kiva/_cython_speedups.cpython-36m-darwin.so
    building 'kiva._marker_renderer' extension
    gcc -Wno-unused-result -Wsign-compare -Wunreachable-code -fno-common -dynamic -DNDEBUG -g -fwrapv -O3 -Wall -g -arch x86_64 -arch x86_64 -DNPY_NO_DEPRECATED_API=NPY_1_7_API_VERSION -Ikiva/markers/agg -Ikiva/markers -I/private/var/folders/j9/ps8s26f91_1_lgf7mtd4smyr0000gn/T/pip-build-env-d8qeockt/overlay/lib/python3.6/site-packages/numpy/core/include -I/Users/aayres/.edm/envs/test-enable/include/python3.6m -c kiva/_marker_renderer.cpp -o build/temp.macosx-10.9-x86_64-3.6/kiva/_marker_renderer.o
    g++ -bundle -undefined dynamic_lookup -g -arch x86_64 -headerpad_max_install_names build/temp.macosx-10.9-x86_64-3.6/kiva/_marker_renderer.o -o /Users/aayres/Desktop/enable/kiva/_marker_renderer.cpython-36m-darwin.so
    building 'kiva.agg._agg' extension
    swigging kiva/agg/agg.i to kiva/agg/agg_wrap.cpp
    swig -python -Ikiva/agg/src -Ikiva/agg/agg-24/include -c++ -o kiva/agg/agg_wrap.cpp kiva/agg/agg.i
    warning: kiva/quartz/CoreFoundation.pxi:121:4: 'CFMutableDictionaryRef' redeclared
    warning: kiva/quartz/CoreFoundation.pxi:138:34: 'kCFTypeDictionaryKeyCallBacks' redeclared
    warning: kiva/quartz/CoreFoundation.pxi:139:36: 'kCFTypeDictionaryValueCallBacks' redeclared
    warning: kiva/quartz/CoreFoundation.pxi:151:4: 'CFAttributedStringRef' redeclared
    warning: kiva/quartz/CoreFoundation.pxi:152:4: 'CFMutableAttributedStringRef' redeclared
    warning: kiva/quartz/CoreFoundation.pxi:163:4: 'CFNumberRef' redeclared
    warning: kiva/quartz/CoreFoundation.pxi:166:8: 'kCFNumberSInt8Type' redeclared
    warning: kiva/quartz/CoreFoundation.pxi:167:8: 'kCFNumberSInt16Type' redeclared
    warning: kiva/quartz/CoreFoundation.pxi:168:8: 'kCFNumberSInt32Type' redeclared
    warning: kiva/quartz/CoreFoundation.pxi:169:8: 'kCFNumberSInt64Type' redeclared
    warning: kiva/quartz/CoreFoundation.pxi:170:8: 'kCFNumberFloat32Type' redeclared
    warning: kiva/quartz/CoreFoundation.pxi:171:8: 'kCFNumberFloat64Type' redeclared
    warning: kiva/quartz/CoreFoundation.pxi:172:8: 'kCFNumberCharType' redeclared
    warning: kiva/quartz/CoreFoundation.pxi:173:8: 'kCFNumberShortType' redeclared
    warning: kiva/quartz/CoreFoundation.pxi:174:8: 'kCFNumberIntType' redeclared
    warning: kiva/quartz/CoreFoundation.pxi:175:8: 'kCFNumberLongType' redeclared
    warning: kiva/quartz/CoreFoundation.pxi:176:8: 'kCFNumberLongLongType' redeclared
    warning: kiva/quartz/CoreFoundation.pxi:177:8: 'kCFNumberFloatType' redeclared
    warning: kiva/quartz/CoreFoundation.pxi:178:8: 'kCFNumberDoubleType' redeclared
    warning: kiva/quartz/CoreFoundation.pxi:179:8: 'kCFNumberCFIndexType' redeclared
    warning: kiva/quartz/CoreGraphics.pxi:12:4: 'CGContextRef' redeclared
    warning: kiva/quartz/CoreGraphics.pxi:14:4: 'CGFloat' redeclared
    warning: kiva/quartz/CoreGraphics.pxi:37:8: 'kCGBlendModeNormal' redeclared
    warning: kiva/quartz/CoreGraphics.pxi:38:8: 'kCGBlendModeMultiply' redeclared
    warning: kiva/quartz/CoreGraphics.pxi:39:8: 'kCGBlendModeScreen' redeclared
    warning: kiva/quartz/CoreGraphics.pxi:40:8: 'kCGBlendModeOverlay' redeclared
    warning: kiva/quartz/CoreGraphics.pxi:41:8: 'kCGBlendModeDarken' redeclared
    warning: kiva/quartz/CoreGraphics.pxi:42:8: 'kCGBlendModeLighten' redeclared
    warning: kiva/quartz/CoreGraphics.pxi:43:8: 'kCGBlendModeColorDodge' redeclared
    warning: kiva/quartz/CoreGraphics.pxi:44:8: 'kCGBlendModeColorBurn' redeclared
    warning: kiva/quartz/CoreGraphics.pxi:45:8: 'kCGBlendModeSoftLight' redeclared
    warning: kiva/quartz/CoreGraphics.pxi:46:8: 'kCGBlendModeHardLight' redeclared
    warning: kiva/quartz/CoreGraphics.pxi:47:8: 'kCGBlendModeDifference' redeclared
    warning: kiva/quartz/CoreGraphics.pxi:48:8: 'kCGBlendModeExclusion' redeclared
    warning: kiva/quartz/CoreGraphics.pxi:49:8: 'kCGBlendModeHue' redeclared
    warning: kiva/quartz/CoreGraphics.pxi:50:8: 'kCGBlendModeSaturation' redeclared
    warning: kiva/quartz/CoreGraphics.pxi:51:8: 'kCGBlendModeColor' redeclared
    warning: kiva/quartz/CoreGraphics.pxi:52:8: 'kCGBlendModeLuminosity' redeclared
    warning: kiva/quartz/CoreGraphics.pxi:55:8: 'kCGLineCapButt' redeclared
    warning: kiva/quartz/CoreGraphics.pxi:56:8: 'kCGLineCapRound' redeclared
    warning: kiva/quartz/CoreGraphics.pxi:57:8: 'kCGLineCapSquare' redeclared
    warning: kiva/quartz/CoreGraphics.pxi:60:8: 'kCGLineJoinMiter' redeclared
    warning: kiva/quartz/CoreGraphics.pxi:61:8: 'kCGLineJoinRound' redeclared
    warning: kiva/quartz/CoreGraphics.pxi:62:8: 'kCGLineJoinBevel' redeclared
    warning: kiva/quartz/CoreGraphics.pxi:65:8: 'kCGPathFill' redeclared
    warning: kiva/quartz/CoreGraphics.pxi:66:8: 'kCGPathEOFill' redeclared
    warning: kiva/quartz/CoreGraphics.pxi:67:8: 'kCGPathStroke' redeclared
    warning: kiva/quartz/CoreGraphics.pxi:68:8: 'kCGPathFillStroke' redeclared
    warning: kiva/quartz/CoreGraphics.pxi:69:8: 'kCGPathEOFillStroke' redeclared
    warning: kiva/quartz/CoreGraphics.pxi:72:8: 'CGRectMinXEdge' redeclared
    warning: kiva/quartz/CoreGraphics.pxi:73:8: 'CGRectMinYEdge' redeclared
    warning: kiva/quartz/CoreGraphics.pxi:74:8: 'CGRectMaxXEdge' redeclared
    warning: kiva/quartz/CoreGraphics.pxi:75:8: 'CGRectMaxYEdge' redeclared
    warning: kiva/quartz/CoreGraphics.pxi:159:4: 'CGColorSpaceRef' redeclared
    warning: kiva/quartz/CoreGraphics.pxi:162:8: 'kCGRenderingIntentDefault' redeclared
    warning: kiva/quartz/CoreGraphics.pxi:163:8: 'kCGRenderingIntentAbsoluteColorimetric' redeclared
    warning: kiva/quartz/CoreGraphics.pxi:164:8: 'kCGRenderingIntentRelativeColorimetric' redeclared
    warning: kiva/quartz/CoreGraphics.pxi:165:8: 'kCGRenderingIntentPerceptual' redeclared
    warning: kiva/quartz/CoreGraphics.pxi:166:8: 'kCGRenderingIntentSaturation' redeclared
    warning: kiva/quartz/CoreGraphics.pxi:169:8: 'kCGColorSpaceUserGray' redeclared
    warning: kiva/quartz/CoreGraphics.pxi:170:8: 'kCGColorSpaceUserRGB' redeclared
    warning: kiva/quartz/CoreGraphics.pxi:171:8: 'kCGColorSpaceUserCMYK' redeclared
    warning: kiva/quartz/CoreGraphics.pxi:174:8: 'kCGColorSpaceGenericGray' redeclared
    warning: kiva/quartz/CoreGraphics.pxi:175:8: 'kCGColorSpaceGenericRGB' redeclared
    warning: kiva/quartz/CoreGraphics.pxi:176:8: 'kCGColorSpaceGenericCMYK' redeclared
    warning: kiva/quartz/CoreGraphics.pxi:186:4: 'CGColorRef' redeclared
    warning: kiva/quartz/CoreGraphics.pxi:225:4: 'CGFontRef' redeclared
    warning: kiva/quartz/CoreGraphics.pxi:226:4: 'CGFontIndex' redeclared
    warning: kiva/quartz/CoreGraphics.pxi:227:4: 'CGGlyph' redeclared
    warning: kiva/quartz/CoreGraphics.pxi:230:8: 'kCGFontIndexMax' redeclared
    warning: kiva/quartz/CoreGraphics.pxi:231:8: 'kCGFontIndexInvalid' redeclared
    warning: kiva/quartz/CoreGraphics.pxi:232:8: 'kCGGlyphMax' redeclared
    warning: kiva/quartz/CoreGraphics.pxi:241:8: 'kCGTextFill' redeclared
    warning: kiva/quartz/CoreGraphics.pxi:242:8: 'kCGTextStroke' redeclared
    warning: kiva/quartz/CoreGraphics.pxi:243:8: 'kCGTextFillStroke' redeclared
    warning: kiva/quartz/CoreGraphics.pxi:244:8: 'kCGTextInvisible' redeclared
    warning: kiva/quartz/CoreGraphics.pxi:245:8: 'kCGTextFillClip' redeclared
    warning: kiva/quartz/CoreGraphics.pxi:246:8: 'kCGTextStrokeClip' redeclared
    warning: kiva/quartz/CoreGraphics.pxi:247:8: 'kCGTextFillStrokeClip' redeclared
    warning: kiva/quartz/CoreGraphics.pxi:248:8: 'kCGTextClip' redeclared
    warning: kiva/quartz/CoreGraphics.pxi:251:8: 'kCGEncodingFontSpecific' redeclared
    warning: kiva/quartz/CoreGraphics.pxi:252:8: 'kCGEncodingMacRoman' redeclared
    warning: kiva/quartz/CoreGraphics.pxi:273:4: 'CGDataProviderRef' redeclared
    warning: kiva/quartz/CoreGraphics.pxi:314:22: 'CGAffineTransformIdentity' redeclared
    warning: kiva/quartz/CoreGraphics.pxi:332:4: 'CGImageRef' redeclared
    warning: kiva/quartz/CoreGraphics.pxi:335:8: 'kCGImageAlphaNone' redeclared
    warning: kiva/quartz/CoreGraphics.pxi:336:8: 'kCGImageAlphaPremultipliedLast' redeclared
    warning: kiva/quartz/CoreGraphics.pxi:337:8: 'kCGImageAlphaPremultipliedFirst' redeclared
    warning: kiva/quartz/CoreGraphics.pxi:338:8: 'kCGImageAlphaLast' redeclared
    warning: kiva/quartz/CoreGraphics.pxi:339:8: 'kCGImageAlphaFirst' redeclared
    warning: kiva/quartz/CoreGraphics.pxi:340:8: 'kCGImageAlphaNoneSkipLast' redeclared
    warning: kiva/quartz/CoreGraphics.pxi:341:8: 'kCGImageAlphaNoneSkipFirst' redeclared
    warning: kiva/quartz/CoreGraphics.pxi:342:8: 'kCGImageAlphaOnly' redeclared
    warning: kiva/quartz/CoreGraphics.pxi:345:8: 'kCGInterpolationDefault' redeclared
    warning: kiva/quartz/CoreGraphics.pxi:346:8: 'kCGInterpolationNone' redeclared
    warning: kiva/quartz/CoreGraphics.pxi:347:8: 'kCGInterpolationLow' redeclared
    warning: kiva/quartz/CoreGraphics.pxi:348:8: 'kCGInterpolationHigh' redeclared
    warning: kiva/quartz/CoreGraphics.pxi:382:4: 'CGPDFDocumentRef' redeclared
    warning: kiva/quartz/CoreGraphics.pxi:418:4: 'CGMutablePathRef' redeclared
    warning: kiva/quartz/CoreGraphics.pxi:419:4: 'CGPathRef' redeclared
    warning: kiva/quartz/CoreGraphics.pxi:452:8: 'kCGPathElementMoveToPoint' redeclared
    warning: kiva/quartz/CoreGraphics.pxi:453:8: 'kCGPathElementAddLineToPoint' redeclared
    warning: kiva/quartz/CoreGraphics.pxi:454:8: 'kCGPathElementAddQuadCurveToPoint' redeclared
    warning: kiva/quartz/CoreGraphics.pxi:455:8: 'kCGPathElementAddCurveToPoint' redeclared
    warning: kiva/quartz/CoreGraphics.pxi:456:8: 'kCGPathElementCloseSubpath' redeclared
    warning: kiva/quartz/CoreGraphics.pxi:462:4: 'CGPathApplierFunction' redeclared
    warning: kiva/quartz/CoreGraphics.pxi:466:4: 'CGFunctionRef' redeclared
    warning: kiva/quartz/CoreGraphics.pxi:468:4: 'CGFunctionEvaluateCallback' redeclared
    warning: kiva/quartz/CoreGraphics.pxi:470:4: 'CGFunctionReleaseInfoCallback' redeclared
    warning: kiva/quartz/CoreGraphics.pxi:483:4: 'CGShadingRef' redeclared
    warning: kiva/quartz/CoreGraphics.pxi:500:4: 'CGLayerRef' redeclared
    error: command 'swig' failed with exit status 1
    ----------------------------------------
ERROR: Command errored out with exit status 1: /Users/aayres/.edm/envs/test-enable/bin/python3 -c 'import sys, setuptools, tokenize; sys.argv[0] = '"'"'/Users/aayres/Desktop/enable/setup.py'"'"'; __file__='"'"'/Users/aayres/Desktop/enable/setup.py'"'"';f=getattr(tokenize, '"'"'open'"'"', open)(__file__);code=f.read().replace('"'"'\r\n'"'"', '"'"'\n'"'"');f.close();exec(compile(code, __file__, '"'"'exec'"'"'))' develop --no-deps Check the logs for full command output.

The current traceback is pretty clear that swig is the problem.
Perhaps we will decide to add a catch for missing swig early with a short error at some point in the future, but at this point this is sufficient I think

@jwiggins
Copy link
Copy Markdown
Member

jwiggins commented Jun 18, 2021

Swig will continue to be a requirement even in the absence of kiva.agg because it's a build requirement for kiva.gl.

@rahulporuri
Copy link
Copy Markdown
Contributor

rahulporuri commented Jun 21, 2021

Swig will continue to be a requirement even in the absence of kiva.agg because it's a build requirement for kiva.gl.

Given this, it might be better to convert the subprocess.Popen into a subprocess.check_call for example and return a modified version of the error we were showing earlier. IMO that's better than the full traceback with just one line "swig failed".

@jvkersch
Copy link
Copy Markdown
Contributor Author

jvkersch commented Jun 21, 2021

@rahulporuri What subprocess.Popen call is that? I only see one call to subprocess.Popen, but that is to invoke git. When it comes to Swig, I think that is handled under the hood by setuptools.

@jwiggins
Copy link
Copy Markdown
Member

jwiggins commented Jun 22, 2021

@jvkersch I believe @rahulporuri was referring to the subprocess.Popen call that was removed by this PR. He's suggesting that instead of removing it completely, we should continue to manually invoke swig as a presence check.

@jvkersch
Copy link
Copy Markdown
Contributor Author

jvkersch commented Jun 22, 2021

That makes sense, thanks for the clarification.

@jvkersch jvkersch closed this Jun 22, 2021
@jvkersch jvkersch mentioned this pull request Jun 22, 2021
Merged
@jwiggins jwiggins deleted the fix-swig-check-setup branch June 22, 2021 08:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rahulporuri rahulporuri Awaiting requested review from rahulporuri

1 more reviewer

@aaronayres35 aaronayres35 aaronayres35 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@jvkersch @jwiggins @rahulporuri @aaronayres35