Test ETS packages from source using cron jobs #162
Merged
Conversation
added 3 commits
June 22, 2019 15:49
and update travis to only install packages from source if the event type is a cron job modified: .travis.yml modified: etstool.py
This is to test the behavior of the install command when the event type is a cron job modified: .travis.yml
modified: .travis.yml
Codecov Report
@@ Coverage Diff @@
## master #162 +/- ##
=======================================
Coverage 39.59% 39.59%
=======================================
Files 155 155
Lines 4592 4592
Branches 519 519
=======================================
Hits 1818 1818
Misses 2734 2734
Partials 40 40Continue to review full report at Codecov.
|
Contributor
Author
|
As expected, pyface, traits and traitsui were installed from source in the travis job. See relevant exceprt from the job log below |
The --source cmdline flag was set for regular CI jobs earlier to test the behavior when the event type is a cron job. Now that the expected behavior has been verified, we remove the flag modified: .travis.yml
Member
|
Nice. LGTM. |
Member
|
@rahulporuri Please merge, but please remember to use squash and merge. |
Contributor
Author
|
FTR i'm not sure when it was added but there already is a cron job running weekly on master. |
This was referenced Jul 6, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The changes introduced in this PR are based on similar changes in the PR enthought/traits#479
Essentially, we do two things here
installcommand to install certain packages from source, via the use of a--sourcecommand line flag--sourceflag when the event type is a cron job.