Skip to content

Test packages from source using cron jobs#479

Merged
rahulporuri merged 2 commits into
masterfrom
ci/travis-cron-job
Jun 18, 2019
Merged

Test packages from source using cron jobs#479
rahulporuri merged 2 commits into
masterfrom
ci/travis-cron-job

Conversation

@rahulporuri
Copy link
Copy Markdown
Contributor

@rahulporuri rahulporuri commented May 13, 2019

  • update travis config to handle cron jobs, using the TRAVIS_EVENT_TYPE environment variable. See https://docs.travis-ci.com/user/cron-jobs/ for more info.
  • update the install command to install packages from source, specifically github, when a specific flag is passed to the command --source.

Together, we will not be able to test the traits package regularly using the master branches of dependencies e.g. traitsui.

Note that the cron job itself will need to be added manually from the settings pane of the travis project page.

Poruri Sai Rahul added 2 commits May 13, 2019 11:09
- update travis config to handle cron jobs, using the TRAVIS_EVENT_TYPE
environment variable
- update the install command to install packages from source,
specifically github, when a specific flag is passed to the command

Together, we will not be able to test the traits package regularly using
the master branches of dependencies e.g. traitsui.

	modified:   .travis.yml
	modified:   etstool.py
	modified:   .travis.yml
@codecov-io
Copy link
Copy Markdown

codecov-io commented May 13, 2019

Codecov Report

Merging #479 into master will increase coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #479      +/-   ##
==========================================
+ Coverage   65.27%   65.28%   +0.01%     
==========================================
  Files          44       44              
  Lines        7061     7061              
  Branches     1412     1412              
==========================================
+ Hits         4609     4610       +1     
  Misses       2030     2030              
+ Partials      422      421       -1
Impacted Files Coverage Δ
traits/has_traits.py 66.97% <0%> (-0.71%) ⬇️
traits/etsconfig/etsconfig.py 63.58% <0%> (+6.17%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d5d4aaf...49527d2. Read the comment docs.

@mdickinson mdickinson self-requested a review May 23, 2019 08:12
Copy link
Copy Markdown
Member

@mdickinson mdickinson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rahulporuri
Copy link
Copy Markdown
Contributor Author

@mdickinson i think a weekly cron job should be enough, right?

@mdickinson
Copy link
Copy Markdown
Member

i think a weekly cron job should be enough, right?

Agreed.

@rahulporuri rahulporuri merged commit af87dd4 into master Jun 18, 2019
@rahulporuri rahulporuri deleted the ci/travis-cron-job branch June 18, 2019 11:53
@rahulporuri
Copy link
Copy Markdown
Contributor Author

rahulporuri commented Jun 18, 2019

Done. I'll duplicate this in the other ETS packages next weekend.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants