Trait container documentation#1058
Merged
Merged
Conversation
mdickinson
reviewed
May 4, 2020
| ``validate(validate(x)) == validate(x)`` should hold as long as | ||
| ``validate(x)`` does not raise an error. | ||
|
|
||
| For example, the following validator casts the list items to integers, |
Member
There was a problem hiding this comment.
Nitpick, but can we spell this as "converts" instead of "casts" (and similarly elsewhere)? C has casts. Python doesn't. (Yes, I know this is a losing battle.)
mdickinson
reviewed
May 4, 2020
| listener systems. They have a fixed signature, which is slightly different for | ||
| lists, dicts and sets, but in all cases starts with the container object itself. | ||
| Notifiers are called in the order that they appear in the notifiers list and | ||
| should not mutate the parameters that they have been passed. |
Member
There was a problem hiding this comment.
Good point; hadn't thought of that.
mdickinson
added a commit
that referenced
this pull request
May 21, 2020
mdickinson
added a commit
that referenced
this pull request
May 22, 2020
* Add changelog for 6.1, release summary is still missing * Comestic fixes * Move Misc item to the bottom * Add placeholder for release date; add recent PRs * Stash partial work before context switch * More updates; move #1058 to correct section; add #1127 * More updates; mostly formatting * Update CHANGES.rst Co-authored-by: Kit Choi <kitchoi@users.noreply.github.com> * More tweaks to wording and content * More wording tweaks * Use short form for View reference * Make use of the intersphinx mapping * Rewordings * Remove broken links * Add recent PRs; fix some long lines * Combine duplicate change entries for Traits / TraitsUI compatibility * Add note about default versus default_value for Either and Union * Add back note that Either will eventually be deprecated. * Remove some duplicate entries; add some missing ones * Ordering * More PRs (sneakily adding #1142 before it's actually merged) Co-authored-by: Kit Yan Choi <kchoi@enthought.com> Co-authored-by: Kit Choi <kitchoi@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added documentation about the new Trait container classes to the internals section, plus some minor clarifications to the section on TraitEvents
Fixes #997.
Checklist
[ ] Tests[ ] Update API reference (docs/source/traits_api_reference)docs/source/traits_user_manual)[ ] Update type annotation hints intraits-stubs