Test against PyQt5 instead of PyQt4#1127
Merged
Merged
Conversation
Member
Author
|
For the record, the tests hang with VS 2015: there's apparently a popup on the worker machine with a message like: "This Windows version (6.3.9600) does not support the required bluetooth API. Consider updating to a more recent Windows (10.0.10685 or above)." This appears to be related to PyQt5: see for example https://stackoverflow.com/q/55205708 |
kitchoi
approved these changes
May 21, 2020
mdickinson
added a commit
that referenced
this pull request
May 21, 2020
mdickinson
added a commit
that referenced
this pull request
May 22, 2020
* Add changelog for 6.1, release summary is still missing * Comestic fixes * Move Misc item to the bottom * Add placeholder for release date; add recent PRs * Stash partial work before context switch * More updates; move #1058 to correct section; add #1127 * More updates; mostly formatting * Update CHANGES.rst Co-authored-by: Kit Choi <kitchoi@users.noreply.github.com> * More tweaks to wording and content * More wording tweaks * Use short form for View reference * Make use of the intersphinx mapping * Rewordings * Remove broken links * Add recent PRs; fix some long lines * Combine duplicate change entries for Traits / TraitsUI compatibility * Add note about default versus default_value for Either and Union * Add back note that Either will eventually be deprecated. * Remove some duplicate entries; add some missing ones * Ordering * More PRs (sneakily adding #1142 before it's actually merged) Co-authored-by: Kit Yan Choi <kchoi@enthought.com> Co-authored-by: Kit Choi <kitchoi@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We should be testing against PyQt 5 instead of PyQt 4 (which is long past its EOL).