Bugs + additional features in checkpoints#112
Merged
Conversation
Collaborator
Author
|
@jmahlmann when you have a moment, could you test the walltime-based dump? it's not yet documented properly, but there is an example in the [checkpoint]
...
# Write a checkpoint once after a fixed walltime
# @type: string
# @default: "" (disabled)
# @note: The format is "HH:MM:SS"
# @note: Useful for long-running simulations to ensure that ...
# @note: ... the simulation can be resumed after allocation expires
# @note: Empty string means disables this (still writes checkpoints on interval)
# @note: This does not exit the simulation
walltime = ""e.g. [checkpoint]
walltime = "23:30:00" |
Collaborator
Author
|
@SChernoglazov I think I fixed the issue with outputs after the restart. this is ready to be tested. |
This was
linked to
issues
Jun 7, 2025
This was referenced Jun 9, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
[REQUEST] Inconsistent Output Write Timing After Restarts #111(will postpone this for now, since it's not really obvious what the ideal behavior must be)Additional fixes
gcc15warnings/errorspath_t = std::filesystem::pathinstead ofstd::stringthroughout the code.infofixed