bugfix for duplicate symbols#81
Merged
haykh merged 3 commits intoentity-toolkit:1.2.0rcfrom Jan 29, 2025
Merged
Conversation
Send/recv buff alias problem
Collaborator
|
@pmocz thanks Philip! kinda weird that with clang19 this warning doesn't show up :\ also, yes, this is one of the reasons i hate c++ so much. in any other language you wouldn't even have to instantiate it at all. the compiler should be able to deduce that from places where the class is used. will merge it to the new release candidate instead of master. |
haykh
approved these changes
Jan 29, 2025
Collaborator
Collaborator
|
@pmocz sorry, i messed up at first so had to hard-reset. now it only has the right fixes. thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes issue: #80
The issue is that:
According to the cpp standard, an explicit instantiation is only allowed to appear once in the entire program.
https://en.cppreference.com/w/cpp/language/class_template
Some gcc compilers will fail if this is not the case.
The challenge is that the member functions of the templated classes have been defined in multiple files (engine_run.cpp, engine_printer.cpp, engine_init.cpp, engine_step_report.cpp). The solution is to only explicitly instantiate the class in
engine_init.cppand then only instantiate rest of the functions in the other files.See:
https://stackoverflow.com/questions/21534435/separate-compilation-and-template-explicit-instantiation