Skip to content

bugfix for duplicate symbols #81

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
haykh merged 3 commits into from
Jan 29, 2025
Merged

bugfix for duplicate symbols #81

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4385c0d
Merge pull request #66 from entity-toolkit/bug/mpich
haykh Oct 15, 2024
530485c
bugfix for duplicate symbols
pmocz Jan 8, 2025
08bc485
rm conflicting file
haykh Jan 29, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 8 additions & 8 deletions src/engines/engine_printer.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -415,13 +415,13 @@ namespace ntt {
}
}

template class Engine<SimEngine::SRPIC, metric::Minkowski<Dim::_1D>>;
template class Engine<SimEngine::SRPIC, metric::Minkowski<Dim::_2D>>;
template class Engine<SimEngine::SRPIC, metric::Minkowski<Dim::_3D>>;
template class Engine<SimEngine::SRPIC, metric::Spherical<Dim::_2D>>;
template class Engine<SimEngine::SRPIC, metric::QSpherical<Dim::_2D>>;
template class Engine<SimEngine::GRPIC, metric::KerrSchild<Dim::_2D>>;
template class Engine<SimEngine::GRPIC, metric::KerrSchild0<Dim::_2D>>;
template class Engine<SimEngine::GRPIC, metric::QKerrSchild<Dim::_2D>>;
template void Engine<SimEngine::SRPIC, metric::Minkowski<Dim::_1D>>::print_report() const;
template void Engine<SimEngine::SRPIC, metric::Minkowski<Dim::_2D>>::print_report() const;
template void Engine<SimEngine::SRPIC, metric::Minkowski<Dim::_3D>>::print_report() const;
template void Engine<SimEngine::SRPIC, metric::Spherical<Dim::_2D>>::print_report() const;
template void Engine<SimEngine::SRPIC, metric::QSpherical<Dim::_2D>>::print_report() const;
template void Engine<SimEngine::GRPIC, metric::KerrSchild<Dim::_2D>>::print_report() const;
template void Engine<SimEngine::GRPIC, metric::KerrSchild0<Dim::_2D>>::print_report() const;
template void Engine<SimEngine::GRPIC, metric::QKerrSchild<Dim::_2D>>::print_report() const;

} // namespace ntt
16 changes: 8 additions & 8 deletions src/engines/engine_run.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,12 +92,12 @@ namespace ntt {
}
}

template class Engine<SimEngine::SRPIC, metric::Minkowski<Dim::_1D>>;
template class Engine<SimEngine::SRPIC, metric::Minkowski<Dim::_2D>>;
template class Engine<SimEngine::SRPIC, metric::Minkowski<Dim::_3D>>;
template class Engine<SimEngine::SRPIC, metric::Spherical<Dim::_2D>>;
template class Engine<SimEngine::SRPIC, metric::QSpherical<Dim::_2D>>;
template class Engine<SimEngine::GRPIC, metric::KerrSchild<Dim::_2D>>;
template class Engine<SimEngine::GRPIC, metric::KerrSchild0<Dim::_2D>>;
template class Engine<SimEngine::GRPIC, metric::QKerrSchild<Dim::_2D>>;
template void Engine<SimEngine::SRPIC, metric::Minkowski<Dim::_1D>>::run();
template void Engine<SimEngine::SRPIC, metric::Minkowski<Dim::_2D>>::run();
template void Engine<SimEngine::SRPIC, metric::Minkowski<Dim::_3D>>::run();
template void Engine<SimEngine::SRPIC, metric::Spherical<Dim::_2D>>::run();
template void Engine<SimEngine::SRPIC, metric::QSpherical<Dim::_2D>>::run();
template void Engine<SimEngine::GRPIC, metric::KerrSchild<Dim::_2D>>::run();
template void Engine<SimEngine::GRPIC, metric::KerrSchild0<Dim::_2D>>::run();
template void Engine<SimEngine::GRPIC, metric::QKerrSchild<Dim::_2D>>::run();
} // namespace ntt
293 changes: 0 additions & 293 deletions src/engines/engine_step_report.cpp
View file
Open in desktop

This file was deleted.

2 changes: 1 addition & 1 deletion src/framework/domain/metadomain.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -390,7 +390,7 @@ namespace ntt {
#if defined(MPI_ENABLED)
auto dx_mins = std::vector<real_t>(g_ndomains);
dx_mins[g_mpi_rank] = dx_min;
MPI_Allgather(&dx_mins[g_mpi_rank],
MPI_Allgather(&dx_min,
1,
mpi::get_type<real_t>(),
dx_mins.data(),
Expand Down