Test on Ruby 3.0 and 3.1 in the CI build #366
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
orien
commented
Jan 9, 2022
Comment on lines
+6
to
+10
| if RUBY_VERSION >= '3.0.0' | ||
| # SparkleFormation has an issue with Ruby 3 and the SortedSet class. | ||
| # Remove after merged: https://github.com/sparkleformation/sparkle_formation/pull/271 | ||
| gem 'faux_sorted_set', require: false | ||
| end |
Member
Author
There was a problem hiding this comment.
SparkleFormation has a problem running on Ruby 3. It uses meta-programming to walk the object graph, which fails when visiting the SortedSet constant. This class was removed from the Ruby standard library in version 3.0. Now the standard library raises an informative error if the SortedSet constant is referenced when an implementation has not been provided via a gem.
Adding this gem resolves the problem by providing a fake SortedSet implementation.
Remove this work-around once a fix is merged and released. Perhaps sparkleformation/sparkle_formation#271
stevehodgkiss
approved these changes
Jan 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ruby 3.0 and 3.1 have been released. Let's test against these latest Ruby versions in the CI build.