Skip to content

Test on Ruby 3.0 and 3.1 in the CI build #366

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
orien merged 3 commits into from
Jan 25, 2022
Merged

Test on Ruby 3.0 and 3.1 in the CI build #366

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ca59808
Support Ruby 3.0 and 3.1
orien Jan 9, 2022
fbdfa94
Resolve SparkleFormation Ruby 3 issue
orien Jan 9, 2022
606bb79
Merge branch 'master' into ruby-3
orien Jan 25, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ jobs:
strategy:
matrix:
os: [ ubuntu-20.04 ]
ruby: [ '2.4', '2.5', '2.6', '2.7' ]
ruby: [ '2.4', '2.5', '2.6', '2.7', '3.0', '3.1' ]
include:
- os: macos-latest
ruby: '2.7'
Expand Down
4 changes: 4 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,8 +10,12 @@ The format is based on [Keep a Changelog], and this project adheres to

## [Unreleased]

### Added

- Test on Ruby 3.0 and 3.1 in the CI build ([#366]).

[Unreleased]: https://github.com/envato/stack_master/compare/v2.13.2...HEAD
[#366]: https://github.com/envato/stack_master/pull/366

## [2.13.2] - 2022-01-25

Expand Down
6 changes: 6 additions & 0 deletions Gemfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,3 +2,9 @@ source 'https://rubygems.org'

# Specify your gem's dependencies in stack_master.gemspec
gemspec

if RUBY_VERSION >= '3.0.0'
# SparkleFormation has an issue with Ruby 3 and the SortedSet class.
# Remove after merged: https://github.com/sparkleformation/sparkle_formation/pull/271
gem 'faux_sorted_set', require: false
end
Comment on lines +6 to +10
Copy link
Member Author

@orien orien Jan 9, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SparkleFormation has a problem running on Ruby 3. It uses meta-programming to walk the object graph, which fails when visiting the SortedSet constant. This class was removed from the Ruby standard library in version 3.0. Now the standard library raises an informative error if the SortedSet constant is referenced when an implementation has not been provided via a gem.

Adding this gem resolves the problem by providing a fake SortedSet implementation.

Remove this work-around once a fix is merged and released. Perhaps sparkleformation/sparkle_formation#271