Use sorted_set gem instead of relying on it existing in ruby's set library
#374
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…library Resolves the following error: StackMaster::TemplateCompiler::TemplateCompilationFailed Failed to compile a_stack_template.rb Caused by: RuntimeError The `SortedSet` class has been extracted from the `set` library. You must use the `sorted_set` gem or other alternatives. In ruby 3.1, the SortedSet class was removed from the `set` library. The sparkle_formation gem has resolved this issue, but has yet to release a new version of the gem. This commit works around the issue by ensuring the SortedSet class in the `sorted_set` gem is used by the sparkle_formation gem.
orien
approved these changes
Jul 28, 2023
Member
orien
left a comment
orien
left a comment
There was a problem hiding this comment.
I hesitated to do this because the problem is not in StackMaster, and only impacts projects using SparkleFormation.
But this is the pragmatic approach. And it's the solution we'll eventually get from SparkleFormation anyway.
Co-authored-by: Orien Madgwick <497874+orien@users.noreply.github.com>
simpson-ross
approved these changes
Jul 28, 2023
Contributor
simpson-ross
left a comment
simpson-ross
left a comment
There was a problem hiding this comment.
Thanks @petervandoros!
runlevel5
approved these changes
Jul 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves the following error:
In ruby 3.1, the SortedSet class was removed from the
setlibrary.The sparkle_formation gem has resolved this issue, but has yet to release a new version of the gem.
This commit works around the issue by ensuring the SortedSet class in the
sorted_setgem is used by the sparkle_formation gem.