Skip to content

Use sorted_set gem instead of relying on it existing in ruby's set library #374

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
petervandoros merged 4 commits into from
Aug 2, 2023
Merged

Use sorted_set gem instead of relying on it existing in ruby's set library #374

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
e60ccbd
Use sorted_set gem instead of relying on it existing in ruby's `set` …
petervandoros Jul 28, 2023
49e1b9d
Bump version to v2.13.4 and update changelog
petervandoros Jul 28, 2023
254eb03
Update CHANGELOG.md to be specific about affected template engines
petervandoros Jul 28, 2023
07b2e2e
Update release date for v2.13.4
petervandoros Aug 2, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,16 @@ The format is based on [Keep a Changelog], and this project adheres to

## [Unreleased]

[Unreleased]: https://github.com/envato/stack_master/compare/v2.13.3...HEAD
[Unreleased]: https://github.com/envato/stack_master/compare/v2.13.4...HEAD

## [2.13.4] - 2023-08-02

### Fixed

- Resolve SparkleFormation template error caused by `SortedSet` class being removed from the `set` library in Ruby 3 ([#374]).

[2.13.3]: https://github.com/envato/stack_master/compare/v2.13.3...v2.13.4
[#374]: https://github.com/envato/stack_master/pull/374

## [2.13.3] - 2023-02-01

Expand Down
6 changes: 0 additions & 6 deletions Gemfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,9 +2,3 @@ source 'https://rubygems.org'

# Specify your gem's dependencies in stack_master.gemspec
gemspec

if RUBY_VERSION >= '3.0.0'
# SparkleFormation has an issue with Ruby 3 and the SortedSet class.
# Remove after merged: https://github.com/sparkleformation/sparkle_formation/pull/271
gem 'faux_sorted_set', require: false
end
2 changes: 1 addition & 1 deletion lib/stack_master/version.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
module StackMaster
VERSION = "2.13.3"
VERSION = "2.13.4"
end
1 change: 1 addition & 0 deletions stack_master.gemspec
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,6 +44,7 @@ Gem::Specification.new do |spec|
spec.add_dependency "aws-sdk-ssm", "~> 1"
spec.add_dependency "aws-sdk-ecr", "~> 1"
spec.add_dependency "aws-sdk-iam", "~> 1"
spec.add_dependency "sorted_set" # remove once new version of sparkle_formation released (> v3.0.40). See https://github.com/sparkleformation/sparkle_formation/pull/271.
spec.add_dependency "diffy"
spec.add_dependency "erubis"
spec.add_dependency "rainbow"
Expand Down