Add decorator with operation name to Route#171
Merged
mattklein123 merged 3 commits intoenvoyproxy:masterfrom Sep 12, 2017
Merged
Add decorator with operation name to Route#171mattklein123 merged 3 commits intoenvoyproxy:masterfrom
mattklein123 merged 3 commits intoenvoyproxy:masterfrom
Conversation
Contributor
Author
|
@htuch @mattklein123 Updated definition as discussed on #170 |
| string path_redirect = 2; | ||
| } | ||
|
|
||
| message TracingDecorator { |
Member
There was a problem hiding this comment.
Thoughts on just naming this "Decorator" ? As I said before I think this may end up getting used beyond tracing. For example we could later add an option to add dynamic stats for this decorated route. Useful for logging also potentially.
htuch
approved these changes
Sep 12, 2017
| // See base.Metadata description. | ||
| Metadata metadata = 4; | ||
|
|
||
| // Decorator for matched route |
Member
There was a problem hiding this comment.
nit: period end of sentence
| } | ||
|
|
||
| message Decorator { | ||
| // The tracing operation (or span name) to be used for the matched route. |
Member
There was a problem hiding this comment.
nit: Can we reword comment to be not tracing specific.
mattklein123
approved these changes
Sep 12, 2017
mattklein123
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.