Skip to content

Add decorator with operation name to Route #171

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mattklein123 merged 3 commits into from
Sep 12, 2017
Merged

Add decorator with operation name to Route #171

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
164e654
tracing: Add decorator with operation name to Route
objectiser Sep 12, 2017
3a9bff3
Rename to be more generic decorator
objectiser Sep 12, 2017
3585f92
Minor changes to comments
objectiser Sep 12, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions api/rds.proto
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -262,6 +262,11 @@ message RedirectAction {
string path_redirect = 2;
}

message Decorator {
// The operation (or span name) to be used for the matched route.
string operation = 1;
}

// The match/action distinction in Route is surfaced explicitly in the v2 API
// [V2-API-DIFF].
message Route {
Expand All @@ -276,6 +281,9 @@ message Route {

// See base.Metadata description.
Metadata metadata = 4;

// Decorator for matched route.
Decorator decorator = 5;
}

// A virtual cluster is a way of specifying a regex matching rule against
Expand Down