Add "crl" field to CertificateValidationContext#358
Merged
mattklein123 merged 4 commits intoenvoyproxy:masterfrom Dec 27, 2017
Merged
Add "crl" field to CertificateValidationContext#358mattklein123 merged 4 commits intoenvoyproxy:masterfrom
mattklein123 merged 4 commits intoenvoyproxy:masterfrom
Conversation
Signed-off-by: Andrew Dunham <adunham@stripe.com>
adunham-stripe
force-pushed
the
adunham/add-crl
branch
from
505cb2b to
3d3d27e
Compare
Signed-off-by: Andrew Dunham <adunham@stripe.com>
adunham-stripe
force-pushed
the
adunham/add-crl
branch
from
3d3d27e to
ff059f8
Compare
| .. _config_listener_ssl_context_crl_file: | ||
|
|
||
| crl_file | ||
| *(optional, string)* An optional `certificate revocation list |
Member
There was a problem hiding this comment.
All of these detailed docs should be copied into the v2 proto comment, as that is where v2 docs come from.
Signed-off-by: Andrew Dunham <adunham@stripe.com>
mattklein123
approved these changes
Dec 22, 2017
Member
mattklein123
left a comment
mattklein123
left a comment
There was a problem hiding this comment.
LGTM, thanks. Will wait to merge to see if anyone elser has any comments.
htuch
approved these changes
Dec 22, 2017
Member
htuch
left a comment
htuch
left a comment
There was a problem hiding this comment.
Out of curiosity, do you need v1 support? If not, we are encouraging a "v2 first" approach in preparation for v1 deprecation.
PiotrSikora
suggested changes
Dec 22, 2017
|
|
||
| // An optional `certificate revocation list | ||
| // <http://https://en.wikipedia.org/wiki/Certificate_revocation_list>`_ | ||
| // (in PEM format). If specified, Envoy will verify that the presented client |
Contributor
There was a problem hiding this comment.
This isn't restricted to client certificates, so please s/client/peer/.
Contributor
Author
There was a problem hiding this comment.
Done and done below!
| crl_file | ||
| *(optional, string)* An optional `certificate revocation list | ||
| <http://https://en.wikipedia.org/wiki/Certificate_revocation_list>`_ (in PEM format). | ||
| If specified, Envoy will verify that the presented client certificate has not been revoked by |
Signed-off-by: Andrew Dunham <adunham@stripe.com>
adunham-stripe
force-pushed
the
adunham/add-crl
branch
from
177eb17 to
d82d917
Compare
PiotrSikora
approved these changes
Dec 23, 2017
mattklein123
approved these changes
Dec 24, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Required in order to verify CRLs in Envoy.
Duplicate of #249
cc @mattklein123