Skip to content

Add "crl" field to CertificateValidationContext #358

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mattklein123 merged 4 commits into from
Dec 27, 2017
Merged

Add "crl" field to CertificateValidationContext #358

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
14e8467
Add "crl" field to CertificateValidationContext
adunham-stripe Oct 25, 2017
ff059f8
Add 'crl_file' to documentation
adunham-stripe Dec 21, 2017
43ef409
Review feedback: copy detailed documentation to v2 proto comment
adunham-stripe Dec 22, 2017
d82d917
Review feedback: change 'client certificate' to 'peer certificate'
adunham-stripe Dec 23, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions api/sds.proto
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -172,6 +172,13 @@ message CertificateValidationContext {

// [#not-implemented-hide:] Must present signed certificate time-stamp.
google.protobuf.BoolValue require_signed_certificate_timestamp = 6;

// An optional `certificate revocation list
// <http://https://en.wikipedia.org/wiki/Certificate_revocation_list>`_
// (in PEM format). If specified, Envoy will verify that the presented peer
// certificate has not been revoked by this CRL. If this file contains
// multiple CRLs, all of them will be used.
DataSource crl = 7;
}

// TLS context shared by both client and server TLS contexts.
Expand Down
9 changes: 9 additions & 0 deletions docs/root/api-v1/listeners/listeners.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -119,6 +119,7 @@ TLS :ref:`architecture overview <arch_overview_ssl>`.
"ca_cert_file": "...",
"verify_certificate_hash": "...",
"verify_subject_alt_name": [],
"crl_file": "...",
"cipher_suites": "...",
"ecdh_curves": "...",
"session_ticket_key_paths": []
Expand Down Expand Up @@ -172,6 +173,14 @@ verify_subject_alt_name
*(optional, array)* An optional list of subject alt names. If specified, Envoy will verify
that the client certificate's subject alt name matches one of the specified values.

.. _config_listener_ssl_context_crl_file:

crl_file
*(optional, string)* An optional `certificate revocation list
Copy link
Copy Markdown
Member

@mattklein123 mattklein123 Dec 22, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All of these detailed docs should be copied into the v2 proto comment, as that is where v2 docs come from.

Copy link
Copy Markdown
Contributor Author

@adunham-stripe adunham-stripe Dec 22, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done!

<http://https://en.wikipedia.org/wiki/Certificate_revocation_list>`_ (in PEM format).
If specified, Envoy will verify that the presented peer certificate has not been revoked by
this CRL. If this file contains multiple CRLs, all of them will be used.

cipher_suites
*(optional, string)* If specified, the TLS listener will only support the specified `cipher list
<https://commondatastorage.googleapis.com/chromium-boringssl-docs/ssl.h.html#Cipher-suite-configuration>`_.
Expand Down