External authorization review comments#491
Merged
htuch merged 3 commits intoenvoyproxy:masterfrom Feb 13, 2018
colabsaumoh:extauthz-review-comments
Merged
External authorization review comments#491htuch merged 3 commits intoenvoyproxy:masterfrom colabsaumoh:extauthz-review-comments
htuch merged 3 commits intoenvoyproxy:masterfrom
colabsaumoh:extauthz-review-comments
Conversation
added 2 commits
February 9, 2018 17:25
Signed-off-by: Saurabh Mohan <saurabh+github@tigera.io>
Signed-off-by: Saurabh Mohan <saurabh+github@tigera.io>
dnoe
previously approved these changes
Feb 12, 2018
wora
reviewed
Feb 12, 2018
| // The filter's behaviour in case the external authorization service does | ||
| // not respond back. If set to true then in case of failure to get a | ||
| // response back from the authorization service allow the traffic. | ||
| // response back from the authorization service or getting a response that is NOT denied then |
Contributor
There was a problem hiding this comment.
Can you wrap the comment at 80-column like the rest of the file?
Signed-off-by: Saurabh Mohan <saurabh+github@tigera.io>
htuch
approved these changes
Feb 13, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Title
Fix up the comments for
failure_mode_allowthat was incorrectly worded and caught during review envoyproxy/envoy#2416cc: @junr03
PS: I removed the comment about the restriction to only envoy_grpc client. That limitation is not really applicable based off the comment by Harvey in the PR#2416. Please do let me know if think it should be there.