Skip to content

External authorization review comments #491

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
htuch merged 3 commits into from
Feb 13, 2018
Merged

External authorization review comments #491

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
22615d2
Fix up comments in external authorization configuration.
Feb 10, 2018
bdbc527
Remove comment about limitation to envoy client of gRPC.
Feb 12, 2018
5344264
Limit to 80 column.
Feb 12, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions envoy/config/filter/http/ext_authz/v2/ext_authz.proto
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,8 @@ import "validate/validate.proto";

// [#not-implemented-hide:]
// External Authorization filter calls out to an external service over the
// gRPC Authorization API defined by :ref:`external_auth <envoy_api_msg_auth.CheckRequest>`.
// gRPC Authorization API defined by
// :ref:`external_auth <envoy_api_msg_auth.CheckRequest>`.
// A failed check will cause this filter to return 403 Forbidden.
message ExtAuthz {

Expand All @@ -18,9 +19,8 @@ message ExtAuthz {

// The filter's behaviour in case the external authorization service does
// not respond back. If set to true then in case of failure to get a
// response back from the authorization service allow the traffic.
// response back from the authorization service or getting a response that
// is NOT denied then traffic will be permitted.
// Defaults to false.
// If set to true and the response from the authorization service is NOT
// Denied then the traffic will be permitted.
bool failure_mode_allow = 2;
}
8 changes: 4 additions & 4 deletions envoy/config/filter/network/ext_authz/v2/ext_authz.proto
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,8 @@ import "validate/validate.proto";

// [#not-implemented-hide:]
// External Authorization filter calls out to an external service over the
// gRPC Authorization API defined by :ref:`external_auth <envoy_api_msg_auth.CheckRequest>`.
// gRPC Authorization API defined by
// :ref:`external_auth <envoy_api_msg_auth.CheckRequest>`.
// A failed check will cause this filter to close the TCP connection.
message ExtAuthz {
// The prefix to use when emitting statistics.
Expand All @@ -20,9 +21,8 @@ message ExtAuthz {

// The filter's behaviour in case the external authorization service does
// not respond back. If set to true then in case of failure to get a
// response back from the authorization service allow the traffic.
// response back from the authorization service or getting a response that
// is NOT denied then traffic will be permitted.
// Defaults to false.
// If set to true and the response from the authorization service is NOT
// Denied then the traffic will be permitted.
bool failure_mode_allow = 3;
}