bridge: fix up proto registration#2702
Merged
alyssawilk merged 1 commit intoenvoyproxy:mainfrom Nov 23, 2022
Merged
Conversation
Signed-off-by: Alyssa Wilk <alyssar@chromium.org>
Contributor
Author
|
cc @danzh2010 |
Contributor
RyanTheOptimist
left a comment
RyanTheOptimist
left a comment
There was a problem hiding this comment.
Yay! Thanks for doing this! One tiny suggestion.
| return std::make_unique< | ||
| envoy_mobile::extensions::cert_validator::platform_bridge::PlatformBridgeCertValidator>(); | ||
| } | ||
| std::string category() const override { return "envoy.tls.cert_validator"; } |
Contributor
There was a problem hiding this comment.
In envoy_build_config/extensions_build_config.bzl, the extension shows up as "envoy_mobile.cert_validator.platform_bridge_cert_validator" (which matches name()). Should these be made consistent? How 'bout we change the name to ""envoy.tls.cert_validator.platform_bridge"? Or maybe this isn't required?
Contributor
Author
There was a problem hiding this comment.
name is still that string (above). I think category is generally different than name so I copied category from CertValidatorFactory
RyanTheOptimist
approved these changes
Nov 23, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes up issues exposed in envoyproxy/envoy#24151 where the PlatformBridgeCertValidatorFactory was not associated with the PlatformBridgeCertValidator proto.
Risk Level: low
Testing: envoyproxy/envoy#24151
Docs Changes: n/a
Release Notes: n/a