mobile: attempting to remove more of protoc#24151
Closed
alyssawilk wants to merge 4 commits intoenvoyproxy:mainfrom
Closed
mobile: attempting to remove more of protoc#24151alyssawilk wants to merge 4 commits intoenvoyproxy:mainfrom
alyssawilk wants to merge 4 commits intoenvoyproxy:mainfrom
Conversation
repokitteh-read-only
Bot
added
the
deps
|
CC @envoyproxy/dependency-shepherds: Your approval is needed for changes made to |
Signed-off-by: Alyssa Wilk <alyssar@chromium.org>
Signed-off-by: Alyssa Wilk <alyssar@chromium.org>
Signed-off-by: Alyssa Wilk <alyssar@chromium.org>
This was referenced Nov 22, 2022
alyssawilk
added a commit
to envoyproxy/envoy-mobile
that referenced
this pull request
Nov 23, 2022
This fixes up issues exposed in envoyproxy/envoy#24151 where the PlatformBridgeCertValidatorFactory was not associated with the PlatformBridgeCertValidator proto. Risk Level: low Testing: envoyproxy/envoy#24151 Docs Changes: n/a Release Notes: n/a Signed-off-by: Alyssa Wilk <alyssar@chromium.org>
alyssawilk
added a commit
that referenced
this pull request
Nov 23, 2022
Currently proto_gen_validate pulls all protos into every unit test, and every unit test validates their existence on start up. This is pretty terrible. bufbuild/protoc-gen-validate#738 pulls this out for Envoy Mobile proto-gen-validate-less builds, and so breaks all the unit tests. Changing the Envoy test framework to only validate proto registration for integration tests. Risk Level: low (should be test only) Testing: #24151 Docs Changes: n/a Release Notes: n/a Signed-off-by: Alyssa Wilk <alyssar@chromium.org>
elliotmjackson
pushed a commit
to bufbuild/protoc-gen-validate
that referenced
this pull request
Nov 28, 2022
before -rwxr-x--- 1 alyssar primarygroup 23338512 Nov 21 17:00 bazel-bin/test/performance/test_binary_size_stripped -rwxr-x--- 1 alyssar primarygroup 23M Nov 21 17:00 bazel-bin/test/performance/test_binary_size_stripped after -rwxr-x--- 1 alyssar primarygroup 19642512 Nov 21 17:04 bazel-bin/test/performance/test_binary_size_stripped -rwxr-x--- 1 alyssar primarygroup 19M Nov 21 17:04 bazel-bin/test/performance/test_binary_size_stripped Proof of concept use here: envoyproxy/envoy#24151 which is passing all Envoy Mobile CI (its failing Envoy CI because of the dependency check which is expected and irrelevant)
jpsim
pushed a commit
that referenced
this pull request
Nov 29, 2022
This fixes up issues exposed in #24151 where the PlatformBridgeCertValidatorFactory was not associated with the PlatformBridgeCertValidator proto. Risk Level: low Testing: #24151 Docs Changes: n/a Release Notes: n/a Signed-off-by: Alyssa Wilk <alyssar@chromium.org> Signed-off-by: JP Simard <jp@jpsim.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Alyssa Wilk alyssar@chromium.org
Commit Message:
Additional Description:
Risk Level:
Testing:
Docs Changes:
Release Notes:
Platform Specific Features:
[Optional Runtime guard:]
[Optional Fixes #Issue]
[Optional Fixes commit #PR or SHA]
[Optional Deprecated:]
[Optional API Considerations:]