test: server test and integration test ipv6#1049
Merged
mattklein123 merged 2 commits intoJun 6, 2017
Merged
Conversation
Merged
htuch
reviewed
Jun 6, 2017
Member
htuch
left a comment
htuch
left a comment
There was a problem hiding this comment.
Looks good, one comment though..
| fake_upstreams_.emplace_back( | ||
| new FakeUpstream(upstream_ssl_ctx_.get(), 0, FakeHttpConnection::Type::HTTP1)); | ||
| new FakeUpstream(upstream_ssl_ctx_.get(), 0, FakeHttpConnection::Type::HTTP1, GetParam())); | ||
| registerPort("upstream_0", fake_upstreams_.back()->localAddress()->ip()->port()); |
Member
There was a problem hiding this comment.
I continue to be an unfan of the use of GetParam() in so many places. It's easy to lose track of what it's referring to. I would prefer a GetIpVersion() or something similar.
htuch
approved these changes
Jun 6, 2017
mattklein123
approved these changes
Jun 6, 2017
jpsim
pushed a commit
that referenced
this pull request
Nov 28, 2022
Description: Split interfaces to allow for creation of a non-Android build target. Risk Level: Low Testing: Local and CI Signed-off-by: Mike Schore <mike.schore@gmail.com> Signed-off-by: JP Simard <jp@jpsim.com>
jpsim
pushed a commit
that referenced
this pull request
Nov 29, 2022
Description: Split interfaces to allow for creation of a non-Android build target. Risk Level: Low Testing: Local and CI Signed-off-by: Mike Schore <mike.schore@gmail.com> Signed-off-by: JP Simard <jp@jpsim.com>
mathetake
added a commit
that referenced
this pull request
Mar 3, 2026
**Description** Follow up on #1013 Signed-off-by: Takeshi Yoneda <t.y.mathetake@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR parameterizes IPv4/IPv6 testing for
See #1036 and #953 .