test: hot restart IPv6#1051
Merged
Merged
Conversation
htuch
reviewed
Jun 6, 2017
| @@ -1,4 +1,4 @@ | |||
| #!/usr/bin/env python | |||
| #!/usr/bin/python2.7 | |||
Member
There was a problem hiding this comment.
I don't think everyone will be running precisely Python 2.7 or have Python in this location. Why the change?
Contributor
Author
There was a problem hiding this comment.
Python 2.3/2.4 doesn't support with open().
Member
There was a problem hiding this comment.
What about /usr/bin/env python2.7 then? You can't assume Python is in /usr/bin.
htuch
reviewed
Jun 6, 2017
| TEST_INDEX=0 | ||
| for HOT_RESTART_JSON in "${JSON_TEST_ARRAY[@]}" | ||
| do | ||
| # Now start the real server, hot restart it twice, and shut it all down as a basic hot restart |
|
|
||
| # Parameterize IPv4 and IPv6 testing. | ||
| if [[ "${ENVOY_IP_TEST_VERSIONS}" == "v4only" ]] || [[ "${ENVOY_IP_TEST_VERSIONS}" == "all" ]] \ | ||
| || [[ -z "${ENVOY_IP_TEST_VERSIONS}" ]]; then |
Member
There was a problem hiding this comment.
It would make sense to have this as the first expression to shortcircuit the other testing.
htuch
approved these changes
Jun 6, 2017
mattklein123
approved these changes
Jun 6, 2017
jpsim
pushed a commit
that referenced
this pull request
Nov 28, 2022
Description: given we have gotten no additional information from the code deleted in this PR, I am deleting to make readability better. This code was previously added to help investigate #1016 and #1017. Risk Level: low Testing: no-op in terms of functionality. Signed-off-by: Jose Nino <jnino@lyft.com> Signed-off-by: JP Simard <jp@jpsim.com>
jpsim
pushed a commit
that referenced
this pull request
Nov 29, 2022
Description: given we have gotten no additional information from the code deleted in this PR, I am deleting to make readability better. This code was previously added to help investigate #1016 and #1017. Risk Level: low Testing: no-op in terms of functionality. Signed-off-by: Jose Nino <jnino@lyft.com> Signed-off-by: JP Simard <jp@jpsim.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR parameterizes IPv4/IPv6 testing for the hot restart integration test.
See #1036 , #953 , and #1049 .