compdb: handling header-only cc_library better#10583
Merged
lizan merged 4 commits intoenvoyproxy:masterfrom Mar 31, 2020
Merged
compdb: handling header-only cc_library better#10583lizan merged 4 commits intoenvoyproxy:masterfrom
lizan merged 4 commits intoenvoyproxy:masterfrom
Conversation
Signed-off-by: Lizan Zhou <lizan@tetrate.io>
Contributor
|
Honestly I don't understand what the role compilation database plays here. My impression is that both this PR and another attempt is to signal the toolchain that it's compiling C++ code and it LGTM I am sorry I cannot reproduce at my local because it never fail on my machine even without this PR :( |
Signed-off-by: Lizan Zhou <lizan@tetrate.io>
Signed-off-by: Lizan Zhou <lizan@tetrate.io>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Lizan Zhou lizan@tetrate.io
Description:
Conditionally add emtpy.cc to cc_library to get a complete compile database. Improve docs as well.
Risk Level: Low (clang-tidy only)
Testing: local