handling header-only envoy_cc_test_library better#10596
Merged
lizan merged 1 commit intoenvoyproxy:masterfrom Mar 31, 2020
Merged
handling header-only envoy_cc_test_library better#10596lizan merged 1 commit intoenvoyproxy:masterfrom
lizan merged 1 commit intoenvoyproxy:masterfrom
Conversation
Signed-off-by: Yuchen Dai <silentdai@gmail.com>
Contributor
Author
|
/assign @lizan |
lizan
approved these changes
Mar 31, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Mostly copied from #10583 but apply to envoy_cc_test_library
Confirmed it fix a little bit in #10491 wrt //test/server:listener_manager_impl_test_lib
Signed-off-by: Yuchen Dai silentdai@gmail.com
Description:
Risk Level:
Testing:
Docs Changes:
Release Notes:
[Optional Fixes #Issue]
[Optional Deprecated:]