deps: Copy protobuf internal headers needed for transcoding#1063
Merged
Conversation
htuch
reviewed
Jun 8, 2017
| # https://github.com/grpc-ecosystem/grpc-httpjson-transcoding | ||
| # TODO(htuch): Clean up protobuf deps builds with envoy-api | ||
| rsync -av --include '*/' --include '*.h' --exclude '*' src/google/protobuf/util/internal $THIRDPARTY_BUILD/include/google/protobuf/util/ | ||
| cp src/google/protobuf/stubs/strutil.h $THIRDPARTY_BUILD/include/google/protobuf/stubs/ |
Member
There was a problem hiding this comment.
Do you want to copy all stubs/*.h to future proof this?
Member
Author
There was a problem hiding this comment.
I don't think so, strutil.h and statusor.h are enough.
htuch
reviewed
Jun 8, 2017
| # These internal headers are needed by the GRPC-JSON transcoding library. | ||
| # https://github.com/grpc-ecosystem/grpc-httpjson-transcoding | ||
| # TODO(htuch): Clean up protobuf deps builds with envoy-api | ||
| rsync -av --include '*/' --include '*.h' --exclude '*' src/google/protobuf/util/internal $THIRDPARTY_BUILD/include/google/protobuf/util/ |
Member
There was a problem hiding this comment.
This could probably be a simpler src/google/protobuf/util/internal/*.h expression...
htuch
approved these changes
Jun 8, 2017
mattklein123
approved these changes
Jun 8, 2017
jpsim
pushed a commit
that referenced
this pull request
Nov 28, 2022
Description: Removes many expired certs; syncs with OpenBSD/LibreSSL. Risk Level: High Testing: Local Signed-off-by: Mike Schore <mike.schore@gmail.com> Signed-off-by: JP Simard <jp@jpsim.com>
jpsim
pushed a commit
that referenced
this pull request
Nov 29, 2022
Description: Removes many expired certs; syncs with OpenBSD/LibreSSL. Risk Level: High Testing: Local Signed-off-by: Mike Schore <mike.schore@gmail.com> Signed-off-by: JP Simard <jp@jpsim.com>
mathetake
added a commit
that referenced
this pull request
Mar 3, 2026
**Description** The configurability for "/v1" was introduced in #1020. However, it is unnecessary configuration no one asked for at the moment given that we keep the rootPrefix for the separation concern between AIGatewayRoutes vs HTTPRoutes. This partially reverts #1020, and removes the config so that we can have a simpler config overall. We can revisit this if anyone asks for it later. If so, I think it will be a time to think about Gateway level CRD. **Related Issues/PRs (if applicable)** Follow up on #1020 --------- Signed-off-by: Takeshi Yoneda <t.y.mathetake@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
for #501
@htuch for review.