Add grpc-httpjson-transcoding dependency#1066
Conversation
|
Looks good, but can you add a description in the commit message of what you're adding? You'll have to wait for the merge of #1063 for this and add the updated CI hash when the Docker image is rebuilt. Also, I wonder if this technically becomes an additional dependency - we're not going to be consuming this as prebuilts, but building each time in CI and developer build, since this is Bazel native. @mattklein123 WDYT? |
|
Yeah, I was concerned about that as well (no prebuilt). Not sure if we should have a hard rule on this or decide on a case by case basis? How long will it take to build this extra code? I assume not that long? |
|
Having another build tool support or invoking bazel inside the deps rule doesn't sound right. The library itself is tiny (~5k lines of code), and it compiles in a few seconds. Unless you're changing its source or compiler options, bazel will cache it so it won't be time consuming for developer builds. |
|
@lizan Explain what these libraries actually do in the commit message, not just why they are being imported. |
Add dependency to the library from https://github.com/grpc-ecosystem/grpc-httpjson-transcoding to provide a RESTful style HTTP/JSON interface for gRPC Service. for envoyproxy#501
lizan
force-pushed
the
grpc_json_transcoding_deps
branch
from
8c3bd2c to
f7a477f
Compare
|
@htuch done |
Signed-off-by: Mike Schore <mike.schore@gmail.com> Signed-off-by: JP Simard <jp@jpsim.com>
Signed-off-by: Mike Schore <mike.schore@gmail.com> Signed-off-by: JP Simard <jp@jpsim.com>
3 participants
for #501