[Windows] Removes abstract mock classes Stream Encoder/Decoder#11480
Merged
mattklein123 merged 1 commit intoJun 10, 2020
Merged
Conversation
Member
Author
Member
|
@davinci26 could you fix DCO and formatting? /wait |
Member
Author
|
@junr03 I will do that. Lemme wait until tomorrow morning to see if anyone has any other comments to batch them together and fix everything in a single iteration. |
davinci26
force-pushed
the
fix-mockStreamEncoderDecoder
branch
from
7da45c0 to
725fe00
Compare
davinci26
force-pushed
the
fix-mockStreamEncoderDecoder
branch
from
725fe00 to
50b13ae
Compare
Signed-off-by: Sotiris Nanopoulos <sonanopo@microsoft.com>
davinci26
force-pushed
the
fix-mockStreamEncoderDecoder
branch
from
50b13ae to
76b90b1
Compare
Member
Author
|
Sorry for the spam folks, configuring DCO turned out to be trickier than I expected |
Member
Author
|
@junr03 ready for a review when you are 😀 |
junr03
approved these changes
Jun 9, 2020
yashwant121
pushed a commit
to yashwant121/envoy
that referenced
this pull request
Jun 24, 2020
…y#11480) Signed-off-by: Sotiris Nanopoulos <sonanopo@microsoft.com> Signed-off-by: yashwant121 <yadavyashwant36@gmail.com>
songhu
pushed a commit
to songhu/envoy
that referenced
this pull request
Jun 25, 2020
…y#11480) Signed-off-by: Sotiris Nanopoulos <sonanopo@microsoft.com>
yashwant121
pushed a commit
to yashwant121/envoy
that referenced
this pull request
Jul 24, 2020
…y#11480) Signed-off-by: Sotiris Nanopoulos <sonanopo@microsoft.com> Signed-off-by: yashwant121 <yadavyashwant36@gmail.com>
lizan
pushed a commit
that referenced
this pull request
Aug 21, 2020
) Similar to #11480. Removes mock class inheritance in MockListenerFactoryContext which prohibits NiceMocks from behaving as expected on Windows\MSVC. Additional Description: Both tests have been passing locally in 1k runs. Risk Level: Low (Test only) Testing: N/A Docs Changes: N/A Release Notes: N/A Signed-off-by: Sotiris Nanopoulos <sonanopo@microsoft.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Sotiris Nanopoulos sonanopo@microsoft.com
Removes abstract mock classes Stream Encoder/Decoder
Additional Description:
As part of our effort to port Envoy to Windows we run into an issue with GTests and GMock in particular that is causing issues when we test on Windows. More specifically chromium documentation:
The way I interpret it is that when you inherit from a Mock class you can not guarantee that the parent Mock class functions are treated as interesting calls. This leads to a GMock warning and consequently a test error. Example base mock classes are
MockStreamEncoderandMockStreamDecoderTests that are now passing:
Risk Level: Low (Test only)
Testing: Tested manually on Windows and Linux
Docs Changes: N/A
Release Notes: N/A