Removes nice mocks from parent class in listener_factory_context#12741
Merged
Conversation
Signed-off-by: Sotiris Nanopoulos <sonanopo@microsoft.com>
Member
Author
|
cc @envoyproxy/windows-dev |
added 2 commits
August 19, 2020 16:46
Signed-off-by: Sotiris Nanopoulos <sonanopo@microsoft.com>
Signed-off-by: Sotiris Nanopoulos <sonanopo@microsoft.com>
lizan
approved these changes
Aug 21, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Sotiris Nanopoulos sonanopo@microsoft.com
Similar to #11480. Removes mock class inheritance in
MockListenerFactoryContextwhich prohibitsNiceMocksfrom behaving as expected on Windows\MSVC.Additional Description:
Both tests have been passing locally in 1k runs.
Risk Level: Low (Test only)
Testing: N/A
Docs Changes: N/A
Release Notes: N/A