extensions: Add extension categories in envoy_cc_extension#14744
Merged
Conversation
Signed-off-by: Ryan Northey <ryan@synca.io>
phlax
requested review from
PiotrSikora,
alyssawilk,
antoniovicente,
asraa,
dio,
ggreenway,
htuch,
jmarantz,
junr03,
lambdai,
lizan,
mattklein123,
snowp and
zuercher
as code owners
Member
Author
|
@htuch hopefully this is doing the right thing - at least so far. to figure out the categories i have used the following command: $ git grep "std::string category() const override " | cut -d' ' -f9 | xargs -I{} bash -c "X={} echo \${X}" | sort | uniq
envoy.access_logger.extension_filters
envoy.access_loggers
envoy.bootstrap
envoy.clusters
envoy.compression.compressor
envoy.compression.decompressor
envoy.dubbo_proxy.filters
...
hopefully this is the ~canonical way to derive the categories. ill start matching them now... |
phlax
commented
Jan 20, 2021
phlax
commented
Jan 25, 2021
Member
Author
|
@htuch apologies for delay on this, i was fighting starlark syntax. i think this is ready for final review. the only one left with |
phlax
commented
Jan 26, 2021
Signed-off-by: Ryan Northey <ryan@synca.io>
Signed-off-by: Ryan Northey <ryan@synca.io>
Member
Author
|
@htuch this should be gtg once tests have passed |
Signed-off-by: Ryan Northey <ryan@synca.io>
phlax
commented
Feb 5, 2021
| "envoy.guarddog_actions", | ||
| "envoy.health_checkers", | ||
| "envoy.internal_redirect_predicates", | ||
| "envoy.io_socket", |
Member
Author
There was a problem hiding this comment.
@htuch i have added envoy.io_socket category reflecting what was in the source/extensions/extensions_build_config.bzl file
afaict there is not a factory for it tho, not sure of the implications
lizan
approved these changes
Feb 5, 2021
Member
Author
|
/retest |
|
Retrying Azure Pipelines: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Commit Message: extensions: Add extension categories in envoy_cc_extension
Additional Description:
This is a breakout PR from #14721
atm it just marks the category as
SOMECATas a marker. I will go through and add correct categories...Risk Level:
Testing:
Docs Changes:
Release Notes:
Platform Specific Features:
[Optional Runtime guard:]
[Optional Fixes #Issue]
[Optional Deprecated:]