-
Notifications
You must be signed in to change notification settings - Fork 5.4k
extensions: Add extension categories in envoy_cc_extension #14744
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
dc14f7c
aa112cb
e682f6a
93c7c75
0e91ba7
4cbe10d
15ef6b9
576c3dc
6c0a3d4
8d81ee7
1982bdf
1cdd307
b2cf10f
d8f7782
8d68036
0a7c387
228ca30
2b996b2
6e334af
3bd9238
37fba55
c6318a0
b1064e1
17ab0c0
387e6e0
9c322e7
eab10a7
0dc0963
577eddc
cdfd929
25634de
0317528
ad9a8b8
a319232
d3a0c02
534b6b6
a434681
7d633a4
4872531
2895c77
4ee0cf5
30233d2
296db77
4550e3c
b5d2a21
aa1156b
b4da8d6
c049821
02895d2
2adc592
19b3f68
65b82bd
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -66,6 +66,38 @@ EXTENSION_SECURITY_POSTURES = [ | |
| "data_plane_agnostic", | ||
| ] | ||
|
|
||
| # Extension categories as defined by factories | ||
| EXTENSION_CATEGORIES = [ | ||
| "envoy.access_loggers", | ||
| "envoy.bootstrap", | ||
| "envoy.clusters", | ||
| "envoy.compression.compressor", | ||
| "envoy.compression.decompressor", | ||
| "envoy.filters.http", | ||
| "envoy.filters.listener", | ||
| "envoy.filters.network", | ||
| "envoy.filters.udp_listener", | ||
| "envoy.formatter", | ||
| "envoy.grpc_credentials", | ||
| "envoy.guarddog_actions", | ||
| "envoy.health_checkers", | ||
| "envoy.internal_redirect_predicates", | ||
| "envoy.io_socket", | ||
|
Member
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. @htuch i have added afaict there is not a factory for it tho, not sure of the implications
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. SGTM |
||
| "envoy.rate_limit_descriptors", | ||
| "envoy.resolvers", | ||
| "envoy.resource_monitors", | ||
| "envoy.retry_host_predicates", | ||
| "envoy.retry_priorities", | ||
| "envoy.stats_sinks", | ||
| "envoy.thrift_proxy.filters", | ||
| "envoy.tracers", | ||
| "envoy.transport_sockets.downstream", | ||
| "envoy.transport_sockets.upstream", | ||
| "envoy.upstreams", | ||
| "envoy.wasm.runtime", | ||
| "DELIBERATELY_OMITTED", | ||
| ] | ||
|
|
||
| EXTENSION_STATUS_VALUES = [ | ||
| # This extension is stable and is expected to be production usable. | ||
| "stable", | ||
|
|
@@ -80,13 +112,22 @@ EXTENSION_STATUS_VALUES = [ | |
| def envoy_cc_extension( | ||
| name, | ||
| security_posture, | ||
| category = None, | ||
| # Only set this for internal, undocumented extensions. | ||
| undocumented = False, | ||
| status = "stable", | ||
| tags = [], | ||
| extra_visibility = [], | ||
| visibility = EXTENSION_CONFIG_VISIBILITY, | ||
| **kwargs): | ||
| if not category: | ||
| fail("Category not set for %s" % name) | ||
|
phlax marked this conversation as resolved.
|
||
| if type(category) == "string": | ||
| category = (category,) | ||
| for cat in category: | ||
| if cat not in EXTENSION_CATEGORIES: | ||
| fail("Unknown extension category for %s: %s" % | ||
| (name, cat)) | ||
| if security_posture not in EXTENSION_SECURITY_POSTURES: | ||
| fail("Unknown extension security posture: " + security_posture) | ||
| if status not in EXTENSION_STATUS_VALUES: | ||
|
|
||
Uh oh!
There was an error while loading. Please reload this page.