api: stop generating v4alpha protos#17842
Merged
lizan merged 4 commits intoenvoyproxy:mainfrom Aug 25, 2021
Merged
Conversation
Signed-off-by: Lizan Zhou <lizan@tetrate.io>
|
CC @envoyproxy/api-shepherds: Your approval is needed for changes made to |
Signed-off-by: Lizan Zhou <lizan@tetrate.io>
Signed-off-by: Lizan Zhou <lizan@tetrate.io>
htuch
approved these changes
Aug 25, 2021
Member
htuch
left a comment
htuch
left a comment
There was a problem hiding this comment.
LGTM, a much smaller change to tooling than I anticipated. Thanks!
tyxia
added a commit
to tyxia/envoy
that referenced
this pull request
Aug 26, 2021
Signed-off-by: Tianyu Xia <tyxia@google.com>
tyxia
added a commit
to tyxia/envoy
that referenced
this pull request
Aug 26, 2021
Signed-off-by: Tianyu Xia <tyxia@google.com>
tyxia
added a commit
to tyxia/envoy
that referenced
this pull request
Aug 26, 2021
Signed-off-by: Tianyu Xia <tyxia@google.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stop generating v4alpha protos as it won't land in foreseeable future.
This fixes go-control-plane sync because of it fails to generate contrib API correctly.
Risk Level: Medium
Testing: CI
Docs Changes: N/A
Release Notes: N/A
Platform Specific Features: N/A