[api] Handle previous message deps sync in contrib api#17855
Closed
fishcakez wants to merge 1 commit intoenvoyproxy:mainfrom
Closed
[api] Handle previous message deps sync in contrib api#17855fishcakez wants to merge 1 commit intoenvoyproxy:mainfrom
fishcakez wants to merge 1 commit intoenvoyproxy:mainfrom
Conversation
Signed-off-by: James Fish <jfish@pinterest.com>
Member
|
Thanks! Though I plan to land #17842 to remove all v4alpha today so this would be no longer an issue. |
Member
|
Fixed by #17842 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Commit Message: Handle previous message deps sync in contrib api
Additional Description: Previously did not correctly handle generating the deps for v4alpha protos inside api contrib, which meant that generated build files could be point at incorrect targets. This was first realized in #17796, which had the v4alpha proto point at the non-contrib v3 location.
Risk Level: Low
Testing: Edit api/contrib/envoy/extensions/filters/network/rocketmq_proxy/v4alpha/ and ran proto format sync to update BUILD files, and included in the commit.
Docs Changes: N/A
Release Notes: N/A
Platform Specific Features: N/A