Rate Limit Quota by sergiitk · Pull Request #19793 · envoyproxy/envoy

sergiitk · 2022-02-03T09:07:48Z

This is an alternative to existing RLS, redesigned for streaming.

Commit Message:
Additional Description:
Risk Level:
Testing:
Docs Changes:
Release Notes:
Platform Specific Features:
[Optional Runtime guard:]
[Optional Fixes #Issue]
[Optional Fixes commit #PR or SHA]
[Optional Deprecated:]
[Optional API Considerations:]

repokitteh-read-only · 2022-02-03T09:07:51Z

As a reminder, PRs marked as draft will not be automatically assigned reviewers,
or be handled by maintainer-oncall triage.

Please mark your PR as ready when you want it to be reviewed!

🐱

Caused by: #19793 was opened by sergiitk.

see: more, trace.

repokitteh-read-only · 2022-02-03T09:07:55Z

CC @envoyproxy/api-shepherds: Your approval is needed for changes made to (api/envoy/|docs/root/api-docs/).
envoyproxy/api-shepherds assignee is @htuch
CC @envoyproxy/api-watchers: FYI only for changes made to (api/envoy/|docs/root/api-docs/).

🐱

Caused by: #19793 was opened by sergiitk.

see: more, trace.

sergiitk · 2022-02-03T09:08:51Z

@tyxia As discussed IRL, please take a look.

markdroth

Thanks for doing this!

Please let me know if you have any questions. Thanks!

tyxia

Thanks for working on this! Some comments from me on the first pass.

PS: Oops. Just noticed some comments are overlapped with Mark's. Those were in my earlier draft(shown in edited history). Forgot to refresh the page before sending out the draft.

tyxia

Thanks for iterating on this!

I haven't gone through the PR thoroughly yet but want to send some comments for early discussion.

tyxia · 2022-02-08T06:11:55Z

/assign @tyxia

markdroth

Making good progress!

Please let me know if you have any questions. Thanks!

htuch · 2022-02-09T05:08:38Z

We need a non-Googler to do API review here as well. Unassigning myself as API shepherd. Suggest @mattklein123 takes a look as someone with rate limit domain experience.

mattklein123 · 2022-02-11T16:05:59Z

I have a high level question before diving into the review. Should this be built into the existing global rate limit filter? It seems like there is a lot of overlap? If this has been discussed somewhere else please let me know and I can take a look. Thank you.

markdroth · 2022-02-11T16:16:36Z

Matt, what we're building here wound up being a whole new protocol with somewhat different semantics to the existing RLS protocol. I think it makes more sense to make it a new filter rather than trying to shoe-horn it into the existing one. I suspect the two would not have much code in common.

yanavlasov

/wait

yanavlasov · 2022-04-11T16:10:37Z

@markdroth @mattklein123 I'm trying to figure out how to best move forward with this extensions. Looking at the protocols as they now, they are quite different and I do not see an easy way to make them compatible. There are maybe some way to make bucket and descriptor specification compatible, not sure how much would be gained from this.

Would it make sense to then brand this filter such that it is Google specific? I.e. GcpRateLimit or GoogleCloudRateLimit? Without reference implementation for the rate limit server that supports this protocol, nobody would be able to use this extension outside of GCP.

sergiitk · 2022-06-24T18:03:06Z

It still unfortunately breaks code review. Please don't do it. If we need to fix DCO we can just do it at the end. Thank you!

Got it, thanks! Sorry for the inconvenience.

Signed-off-by: Sergii Tkachenko <sergiitk@google.com>

sergiitk · 2022-06-24T22:15:51Z

@mattklein123 All set! Ready for another round.

Signed-off-by: Sergii Tkachenko <sergiitk@google.com>

mattklein123

Thanks LGTM with one remaining comment. Thank you!

/wait

Signed-off-by: Sergii Tkachenko <sergiitk@google.com>

mattklein123

Thanks!

sergiitk · 2022-06-30T17:18:18Z

@mattklein123 We didn't coordinate removing the filter - will make a separate PR right now.

RLQS API added in envoyproxy#19793. This change removes the docs and adds [#not-implemented-hide:] tags until the implementation is ready. Signed-off-by: Sergii Tkachenko <sergiitk@google.com>

RLQS API added in #19793. This change removes the docs and adds [#not-implemented-hide:] tags until the implementation is ready. Signed-off-by: Sergii Tkachenko <sergiitk@google.com>

RLQS API added in envoyproxy/envoy#19793. This change removes the docs and adds [#not-implemented-hide:] tags until the implementation is ready. Signed-off-by: Sergii Tkachenko <sergiitk@google.com> Mirrored from https://github.com/envoyproxy/envoy @ 3af90c11e40ecf175aaa830a5e1daebd15551b54

RLQS API added in envoyproxy/envoy#19793. This change removes the docs and adds [#not-implemented-hide:] tags until the implementation is ready. Signed-off-by: Sergii Tkachenko <sergiitk@google.com>

repokitteh-read-only Bot added the api label Feb 3, 2022

repokitteh-read-only Bot assigned htuch Feb 3, 2022

sergiitk mentioned this pull request Feb 3, 2022

[WIP] Rate Limit Quota sergiitk/envoy#1

Open

markdroth reviewed Feb 7, 2022

View reviewed changes

tyxia reviewed Feb 7, 2022

View reviewed changes

tyxia reviewed Feb 8, 2022

View reviewed changes

repokitteh-read-only Bot assigned tyxia Feb 8, 2022

yanavlasov self-assigned this Feb 8, 2022

markdroth reviewed Feb 8, 2022

View reviewed changes

htuch removed their assignment Feb 9, 2022

mattklein123 self-assigned this Feb 9, 2022

yanavlasov requested changes Feb 14, 2022

View reviewed changes

Comment thread api/envoy/extensions/filters/http/rate_limit_quota/v3/rate_limit_quota.proto Outdated

Comment thread api/envoy/type/v3/ratelimit_strategy.proto Outdated

Comment thread api/envoy/extensions/filters/http/rate_limit_quota/v3/rate_limit_quota.proto Outdated

repokitteh-read-only Bot added the waiting label Feb 14, 2022

kyessenov mentioned this pull request Mar 1, 2022

Ratelimit by count in header #20124

Closed

kyessenov reviewed Mar 2, 2022

View reviewed changes

Comment thread api/envoy/extensions/filters/http/rate_limit_quota/v3/rate_limit_quota.proto Outdated

kyessenov reviewed Mar 2, 2022

View reviewed changes

Comment thread api/envoy/extensions/filters/http/rate_limit_quota/v3/rate_limit_quota.proto Outdated

yanavlasov requested changes Apr 1, 2022

View reviewed changes

Comment thread api/envoy/type/v3/ratelimit_strategy.proto Outdated

yanavlasov reviewed Apr 1, 2022

View reviewed changes

Comment thread api/envoy/extensions/filters/http/rate_limit_quota/v3/rate_limit_quota.proto Outdated

yanavlasov reviewed Apr 1, 2022

View reviewed changes

Comment thread api/envoy/type/v3/ratelimit_strategy.proto Outdated

yanavlasov reviewed Apr 1, 2022

View reviewed changes

Comment thread api/envoy/extensions/filters/http/rate_limit_quota/v3/rate_limit_quota.proto Outdated

repokitteh-read-only Bot removed the waiting label Apr 2, 2022

mattklein123 added the waiting label Apr 5, 2022

Address API shepards' feedback round 2; improve and expand wording

699957e

Signed-off-by: Sergii Tkachenko <sergiitk@google.com>

repokitteh-read-only Bot removed the waiting label Jun 24, 2022

sergiitk requested a review from mattklein123 June 24, 2022 22:15

Fix lint: spelling (though disagreeable); remove unused import

39e9f7b

Signed-off-by: Sergii Tkachenko <sergiitk@google.com>

mattklein123 requested changes Jun 28, 2022

View reviewed changes

Comment thread api/envoy/extensions/filters/http/rate_limit_quota/v3/rate_limit_quota.proto Outdated

repokitteh-read-only Bot added the waiting label Jun 28, 2022

Feedback: filter_enforced defaults to 100%

ad0fdd1

Signed-off-by: Sergii Tkachenko <sergiitk@google.com>

repokitteh-read-only Bot removed the waiting label Jun 28, 2022

Merge branch 'main' into rlqs

ab15657

Signed-off-by: Sergii Tkachenko <sergiitk@google.com>

sergiitk requested a review from mattklein123 June 28, 2022 18:44

mattklein123 approved these changes Jun 29, 2022

View reviewed changes

repokitteh-read-only Bot removed the api label Jun 29, 2022

mattklein123 removed their assignment Jun 29, 2022

yanavlasov approved these changes Jun 30, 2022

View reviewed changes

yanavlasov merged commit 259d76e into envoyproxy:main Jun 30, 2022

sergiitk mentioned this pull request Jun 30, 2022

RLQS: hide unimplemented documentation #21966

Merged

sergiitk deleted the rlqs branch June 30, 2022 18:33

sergiitk mentioned this pull request Jul 12, 2022

rlqs: Add per route runtime overrides #22150

Closed

mattklein123 mentioned this pull request Oct 14, 2022

Add gRPC proto for rate-limit xDS Config communication envoyproxy/ratelimit#368

Closed

Conversation

sergiitk commented Feb 3, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

repokitteh-read-only Bot commented Feb 3, 2022

Uh oh!

repokitteh-read-only Bot commented Feb 3, 2022

Uh oh!

sergiitk commented Feb 3, 2022

Uh oh!

markdroth left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

tyxia left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

tyxia left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

tyxia commented Feb 8, 2022

Uh oh!

markdroth left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

htuch commented Feb 9, 2022

Uh oh!

mattklein123 commented Feb 11, 2022

Uh oh!

markdroth commented Feb 11, 2022

Uh oh!

yanavlasov left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

yanavlasov commented Apr 11, 2022

Uh oh!

sergiitk commented Jun 24, 2022

Uh oh!

sergiitk commented Jun 24, 2022

Uh oh!

mattklein123 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

mattklein123 left a comment

sergiitk commented Feb 3, 2022 •

edited

Loading

tyxia left a comment •

edited

Loading