RLQS: hide unimplemented documentation#21966
Merged
mattklein123 merged 1 commit intoenvoyproxy:mainfrom Jul 6, 2022
Merged
Conversation
RLQS API added in envoyproxy#19793. This change removes the docs and adds [#not-implemented-hide:] tags until the implementation is ready. Signed-off-by: Sergii Tkachenko <sergiitk@google.com>
|
CC @envoyproxy/api-shepherds: Your approval is needed for changes made to |
Member
|
/docs |
|
Docs for this Pull Request will be rendered here: https://storage.googleapis.com/envoy-pr/21966/docs/index.html The docs are (re-)rendered each time the CI |
Contributor
Author
|
CC folks that reviewed the original PR @yanavlasov @markdroth @mattklein123 |
Merged
htuch
approved these changes
Jul 1, 2022
Member
htuch
left a comment
htuch
left a comment
There was a problem hiding this comment.
Sure, makes sense to hide, in particular if implementation is not pending.
Contributor
Author
|
@htuch feel free to merge this, unless it needs any extra changes. |
tyxia
added a commit
to tyxia/envoy
that referenced
this pull request
Jul 12, 2022
This reverts commit 3af90c1.
tyxia
added a commit
to tyxia/envoy
that referenced
this pull request
Jul 12, 2022
This reverts commit 3af90c1. Signed-off-by: Tianyu Xia <tyxia@google.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
RLQS API added in #19793.
This change removes the docs and adds [#not-implemented-hide:] tags
until the implementation is ready.
Signed-off-by: Sergii Tkachenko sergiitk@google.com
Commit Message: RLQS: hide unimplemented documentation
Additional Description: RLQS API added in #19793.
This change removes the docs and adds [#not-implemented-hide:] tags until the implementation is ready.
Risk Level:
Testing:
Docs Changes: Hides RLQS documentation
Release Notes:
Platform Specific Features:
[Optional Runtime guard:]
[Optional Fixes #Issue]
[Optional Fixes commit #PR or SHA]
[Optional Deprecated:]
[Optional API Considerations:]