test: fix slow test from previous commit#216
Merged
mattklein123 merged 1 commit intomasterfrom Nov 13, 2016
Merged
Conversation
This test is still too slow for what it is doing but this makes it acceptable for now.
Member
Author
|
@lyft/network-team @RomanDzhabarov |
Member
|
Made it comparable to other tests run time: #217 |
lizan
pushed a commit
to lizan/envoy
that referenced
this pull request
Nov 25, 2019
Signed-off-by: crazyxy <yxyan@google.com>
douglas-reid
referenced
this pull request
in douglas-reid/envoy
Jun 8, 2020
Signed-off-by: Pengyuan Bian <bianpengyuan@google.com>
krinkinmu
pushed a commit
to krinkinmu/envoy
that referenced
this pull request
Nov 1, 2024
Removed .github/dependabot.yml file
mathetake
pushed a commit
that referenced
this pull request
Mar 3, 2026
**Commit Message**: Previously, API keys read from a file were used as-is, which could lead to authentication failures if the file contained unintended leading or trailing whitespace (e.g., from manual edits or file generation issues). This change ensures that the API key is trimmed before use, preventing such issues. A test case has been updated to validate the behavior. Additionally, a debug log is added to warn if trimming occurs, helping diagnose unexpected formatting issues. Signed-off-by: Sébastien Han <seb@redhat.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This test is still too slow for what it is doing but this makes it
acceptable for now.