[balsa] Fix 304WithBody test and add new one.#24058
Closed
bencebeky wants to merge 3 commits intoenvoyproxy:mainfrom
bencebeky:304
Closed
[balsa] Fix 304WithBody test and add new one.#24058bencebeky wants to merge 3 commits intoenvoyproxy:mainfrom bencebeky:304
bencebeky wants to merge 3 commits intoenvoyproxy:mainfrom
bencebeky:304
Conversation
Signed-off-by: Bence Béky <bnc@google.com>
Add //test/common/http/http1:codec_impl_test test case for 304 response with body for both BalsaParser and http-parser. In this test, the body is dispatched to the parser in the same Parser::execute() call as the headers. Modify ProtocolIntegrationTest.304WithBody by appending '\r\n' to the end of the "body" of the 304 response, necessary for BalsaParser to signal an error. Signed-off-by: Bence Béky <bnc@google.com>
Signed-off-by: Bence Béky <bnc@google.com>
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add //test/common/http/http1:codec_impl_test test case for 304 response
with body for both BalsaParser and http-parser. In this test, the body
is dispatched to the parser in the same Parser::execute() call as the
headers.
Modify ProtocolIntegrationTest.304WithBody by appending '\r\n' to the
end of the "body" of the 304 response, necessary for BalsaParser to
signal an error.
Tracking issue: #21245
Also include #24003 (GitHub does not support dependent PRs)
Signed-off-by: Bence Béky bnc@google.com
Commit Message: [balsa] Fix 304WithBody test and add new one.
Additional Description:
Risk Level: low, test-only change
Testing: //test/integration:protocol_integration_test
Docs Changes: n/a
Release Notes: n/a
Platform Specific Features: n/a