Skip to content

[balsa] Fix 304WithBody test and add new one.#24058

Closed
bencebeky wants to merge 3 commits intoenvoyproxy:mainfrom
bencebeky:304
Closed

[balsa] Fix 304WithBody test and add new one.#24058
bencebeky wants to merge 3 commits intoenvoyproxy:mainfrom
bencebeky:304

Conversation

@bencebeky
Copy link
Copy Markdown
Contributor

Add //test/common/http/http1:codec_impl_test test case for 304 response
with body for both BalsaParser and http-parser. In this test, the body
is dispatched to the parser in the same Parser::execute() call as the
headers.

Modify ProtocolIntegrationTest.304WithBody by appending '\r\n' to the
end of the "body" of the 304 response, necessary for BalsaParser to
signal an error.

Tracking issue: #21245

Also include #24003 (GitHub does not support dependent PRs)

Signed-off-by: Bence Béky bnc@google.com

Commit Message: [balsa] Fix 304WithBody test and add new one.
Additional Description:
Risk Level: low, test-only change
Testing: //test/integration:protocol_integration_test
Docs Changes: n/a
Release Notes: n/a
Platform Specific Features: n/a

Signed-off-by: Bence Béky <bnc@google.com>
Add //test/common/http/http1:codec_impl_test test case for 304 response
with body for both BalsaParser and http-parser.  In this test, the body
is dispatched to the parser in the same Parser::execute() call as the
headers.

Modify ProtocolIntegrationTest.304WithBody by appending '\r\n' to the
end of the "body" of the 304 response, necessary for BalsaParser to
signal an error.

Signed-off-by: Bence Béky <bnc@google.com>
@repokitteh-read-only
Copy link
Copy Markdown

As a reminder, PRs marked as draft will not be automatically assigned reviewers,
or be handled by maintainer-oncall triage.

Please mark your PR as ready when you want it to be reviewed!

🐱

Caused by: #24058 was opened by bencebeky.

see: more, trace.

Signed-off-by: Bence Béky <bnc@google.com>
@bencebeky
Copy link
Copy Markdown
Contributor Author

Now that #24003 landed, abandoning in favor of a new PR with clean history. The only purpose of this temporary PR was to see if presubmits pass, and if not, be able to start working on that while waiting for #24003.

@bencebeky bencebeky closed this Nov 21, 2022
@bencebeky bencebeky deleted the 304 branch November 21, 2022 22:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants