[balsa] Run HttpProtocolIntegrationTests with BalsaParser as well.#24003
Merged
KBaichoo merged 7 commits intoenvoyproxy:mainfrom Nov 21, 2022
bencebeky:integration
Merged
[balsa] Run HttpProtocolIntegrationTests with BalsaParser as well.#24003KBaichoo merged 7 commits intoenvoyproxy:mainfrom bencebeky:integration
KBaichoo merged 7 commits intoenvoyproxy:mainfrom
bencebeky:integration
Conversation
Set up HttpProtocolIntegrationTest and its derived test classes, as well as Http2BufferWatermarksTest (a class derived from HttpIntegrationTest) to run with BalsaParser in addition to http-parser if either the upstream or the downstream protocol is HTTP/1.1. Disable BalsaParser for now for a few tests that are failing. Signed-off-by: Bence Béky <bnc@google.com>
…th BalsaHeaders. Signed-off-by: Bence Béky <bnc@google.com>
Signed-off-by: Bence Béky <bnc@google.com>
The following tests time out after five minutes with TSAN because of the increased number of test cases: //test/integration:overload_integration_test //test/extensions/filters/http/health_check:health_check_integration_test Signed-off-by: Bence Béky <bnc@google.com>
Signed-off-by: Bence Béky <bnc@google.com>
Contributor
Author
This was referenced Nov 17, 2022
diannahu
previously approved these changes
Nov 17, 2022
Only HTTP/1 overrides will be used in test/integration/integration_test.h in a subsequent PR. Signed-off-by: Bence Béky <bnc@google.com>
diannahu
approved these changes
Nov 18, 2022
Signed-off-by: Bence Béky <bnc@google.com>
Contributor
Author
|
/assign @KBaichoo |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Set up HttpProtocolIntegrationTest and its derived test classes, as well as Http2BufferWatermarksTest (a class derived from HttpIntegrationTest) to run with BalsaParser in addition to http-parser if either the upstream or the downstream protocol is HTTP/1.1. Disable BalsaParser for now for a few tests that are failing.
Also bump shard counts for the following two tests:
//test/integration:overload_integration_test
//test/extensions/filters/http/health_check:health_check_integration_test
This is because the increased number of test cases resulted in timeouts (against the five minute limit) of TSAN runs.
Tracking issue: #21245
Signed-off-by: Bence Béky bnc@google.com
Commit Message: [balsa] Run HttpProtocolIntegrationTests with BalsaParser as well.
Additional Description:
Risk Level: low, test-only change
Testing: //test/integration:all
Docs Changes: n/a
Release Notes: n/a
Platform Specific Features: n/a