Increase shard count for //test/integration:websocket_integration_test.#24252
Merged
KBaichoo merged 1 commit intoenvoyproxy:mainfrom Nov 30, 2022
bencebeky:shard
Merged
Increase shard count for //test/integration:websocket_integration_test.#24252KBaichoo merged 1 commit intoenvoyproxy:mainfrom bencebeky:shard
KBaichoo merged 1 commit intoenvoyproxy:mainfrom
bencebeky:shard
Conversation
I have seen TSAN test timeouts, for example, in #24108. This is presumably due to #24003 increasing the test parameter space two-fold for HttpProtocolIntegrationTest and its derived classes, like WebsocketIntegrationTest. Increase shard count to prevent timeouts. Signed-off-by: Bence Béky <bnc@google.com>
Contributor
Author
|
/assign @KBaichoo |
KBaichoo
approved these changes
Nov 29, 2022
Member
|
i have spotted this flake albeit infrequently in the wild - i have a feeling it may affect other branches also so we might want to /backport this |
repokitteh-read-only
Bot
added
the
backport/review
Member
|
i checked azp analytics and seems this is |
Contributor
Author
Thank you for checking. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I have seen TSAN test timeouts, for example, in #24108. This is presumably due to #24003 increasing the test parameter space two-fold for HttpProtocolIntegrationTest and its derived classes, like WebsocketIntegrationTest. Increase shard count to prevent timeouts.
Tracking issue: #21245
Signed-off-by: Bence Béky bnc@google.com
Commit Message: Increase shard count for //test/integration:websocket_integration_test.
Additional Description:
Risk Level: low, test-only change
Testing: //test/integration:websocket_integration_test
Docs Changes: n/a
Release Notes: n/a
Platform Specific Features: n/a