ci: run DrString against Xcode 14.1#24223
Merged
alyssawilk merged 2 commits intomainfrom Nov 28, 2022
Merged
Conversation
Matching the Xcode version used for other `mobile/**` CI jobs. Signed-off-by: JP Simard <jp@jpsim.com>
alyssawilk
approved these changes
Nov 28, 2022
Contributor
|
so I'm OK merging as-is, but it might be worth picking up #24212 just to make sure it runs cleanly. theoretically it should as it works for downstream E-M but I had enough things break in weird ways t can't hurt to double check. |
Contributor
Author
|
I've updated the branch to pull in #24212, sorry I didn't realize my local repo was out of date. |
alyssawilk
approved these changes
Nov 28, 2022
Contributor
alyssawilk
left a comment
alyssawilk
left a comment
There was a problem hiding this comment.
There have been so many changes to the yaml files today it's hard to not be behind ;-)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Commit Message: ci: run DrString against Xcode 14.1
Additional Description: Matching the Xcode version used for other
mobile/**CI jobs.Risk Level: None
Testing: Previously set on envoyproxy/envoy-mobile
Docs Changes: None
Release Notes: None
Platform Specific Features: Only runs on changes to
mobile/**