Repo merge clean diffs#24104
Conversation
Signed-off-by: Alyssa Wilk <alyssar@chromium.org>
alyssawilk
force-pushed
the
repo_merge_clean_diffs
branch
9 times, most recently
from
d749f8d to
9f89d48
Compare
Signed-off-by: Alyssa Wilk <alyssar@chromium.org>
alyssawilk
force-pushed
the
repo_merge_clean_diffs
branch
from
9f89d48 to
c2467cf
Compare
alyssawilk
requested review from
Augustyniak,
RyanTheOptimist,
abeyad and
jpsim
as code owners
RyanTheOptimist
left a comment
RyanTheOptimist
left a comment
There was a problem hiding this comment.
Exciting! Assuming this works (passes CI), LGTM!
RyanTheOptimist
left a comment
RyanTheOptimist
left a comment
There was a problem hiding this comment.
Exciting! Assuming this works (passes CI), LGTM!
Following the Envoy-Mobile [project merge](envoyproxy/envoy#24104) this PR fixes the bazel query to fetch the fuzzers. Signed-off-by: Adi Suissa-Peleg <adip@google.com> Signed-off-by: Adi Suissa-Peleg <adip@google.com>
|
|
||
| jobs: | ||
| retest: | ||
| name: Retest |
There was a problem hiding this comment.
FYI this means that /retest won't retest failed GitHub Actions jobs.
Where could I look at how Repokitteh is setup so maybe I could teach it to do that?
There was a problem hiding this comment.
I'm fine adding it back, I just was trying to start with CI workflows that verified we didn't break the build :-)
repokitteh files for Envoy are here: ci/repokitteh/modules
| submodules: true | ||
| - name: Add safe directory | ||
| run: git config --global --add safe.directory /__w/envoy-mobile/envoy-mobile | ||
| run: git config --global --add safe.directory /__w/envoy/envoy |
There was a problem hiding this comment.
I don't think these are needed anymore because there's no git submodule involved anymore, just the main git repo.
There was a problem hiding this comment.
CI broke without them, and told me to add them back.
| env: | ||
| DEVELOPER_DIR: /Applications/Xcode_14.1.app | ||
| run: ./bazelw run @DrString//:drstring check | ||
| DEVELOPER_DIR: /Applications/Xcode_14.0.app |
There was a problem hiding this comment.
Why did we revert from Xcode 14.1 to Xcode 14.0 here?
There was a problem hiding this comment.
argh, my original pull was before the bump and the . files kept being problematic. will fix thanks for the catch
Commit Message: Add missing .bazelproject files. This fixes a dev workflow which allows us to run example/test applications from within Android Studio IDE. The addition of the .bazelrpoject was most probably missed in #24104 as dot files are ignored by default in Envoy repo. Risk Level: Low Testing: N/A Docs Changes: N/A Release Notes: N/A Platform Specific Features: N/A Signed-off-by: Rafal Augustyniak <raugustyniak@lyft.com>
Following the Envoy-Mobile [project merge](envoyproxy/envoy#24104) this PR fixes the bazel query to fetch the fuzzers. Signed-off-by: Adi Suissa-Peleg <adip@google.com> Signed-off-by: Adi Suissa-Peleg <adip@google.com>
4 participants
Full repo merge.
Push one:
copied the entire envoy mobile repo into Envoy as is from d1350ec9a42077267c7b19348f49d4da5502d191
copied EM workflows into the Envoy workflow directory
Push 2:
change mobile/envoy to a symlink to the ../ envoy repo instead
add a few files missed in push 1
several file fixups to pass lint (upstreamed in PR envoyproxy/envoy-mobile#2684)
removing proto and absl patches from E-M
edited EM workflows to run from the mobile directory and only run iff mobile/** paths changed (see diffs between first and second PR)
-- disabling swift lint because I can't get it to work.
-- disabling perf because it can't work on first check in (compares to clean head)
-- release validation because it's having OS issues
Risk Level: added EM CI
Testing: new EM tests
Docs Changes: n/a
Release Notes: none
most of #23758