Skip to content

mobile tools: add missing .bazelproject files#24228

Merged
alyssawilk merged 2 commits intomainfrom
add-missing-bazelproject-files
Nov 29, 2022
Merged

mobile tools: add missing .bazelproject files#24228
alyssawilk merged 2 commits intomainfrom
add-missing-bazelproject-files

Conversation

@Augustyniak
Copy link
Copy Markdown
Contributor

@Augustyniak Augustyniak commented Nov 28, 2022

Commit Message: Add missing .bazelproject files. This fixes a dev workflow which allows us to run example/test applications from within Android Studio IDE. The addition of the .bazelrpoject was most probably missed in #24104 as dot files are ignored by default in Envoy repo.
Risk Level: Low
Testing: N/A
Docs Changes: N/A
Release Notes: N/A
Platform Specific Features: N/A

Copy link
Copy Markdown
Contributor

@alyssawilk alyssawilk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great catch, thank you!

Copy link
Copy Markdown
Contributor

@jpsim jpsim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

Also adding these in #24233

@Augustyniak
Copy link
Copy Markdown
Contributor Author

/merge

@alyssawilk alyssawilk merged commit d21aab4 into main Nov 29, 2022
@mattklein123 mattklein123 deleted the add-missing-bazelproject-files branch January 20, 2023 16:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants