http: fixing 100-continue behavior#2560
Merged
mattklein123 merged 1 commit intoenvoyproxy:masterfrom Feb 8, 2018
Merged
Conversation
Signed-off-by: Alyssa Wilk <alyssar@chromium.org>
mattklein123
approved these changes
Feb 8, 2018
Member
mattklein123
left a comment
mattklein123
left a comment
There was a problem hiding this comment.
Thanks for the quick turnaround. Will go ahead and merge this but small comment nit if you feel like a follow up next week.
| // and sends the 100-Continue directly to the encoder. | ||
| chargeStats(continueHeader()); | ||
| response_encoder_->encode100ContinueHeaders(continueHeader()); | ||
| // Remove the Expect header so it won't be handled again downstream. |
Member
There was a problem hiding this comment.
nit: s/downstream/upstream?
mattklein123
added a commit
that referenced
this pull request
Feb 9, 2018
This reverts commit 3f9853b. Signed-off-by: Matt Klein <mklein@lyft.com>
Closed
alyssawilk
added a commit
to alyssawilk/envoy
that referenced
this pull request
Feb 9, 2018
Signed-off-by: Alyssa Wilk <alyssar@chromium.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Restoring the previous behavior where Envoy strips the Expect header when seeing expect: 100-continue
Risk Level: Low
Testing: integration test
Docs Changes: n/a
Release Notes: n/a