Revert 100 continue#2564
Closed
mattklein123 wants to merge 2 commits intomasterfrom
Closed
Conversation
alyssawilk
approved these changes
Feb 9, 2018
Member
Author
|
cc @junr03 |
Member
Author
|
IMO we can close this revert. I think @alyssawilk has a full understanding of the underlying issue and the 2nd fix should get us into a decent state, at least no worse than we were previously. There are follow up fixes coming for robustness, etc. but I feel comfortable either way. @alyssawilk up to you whether you want to merge or close. |
Member
Author
|
@junr03 can you go to canary with current master tomorrow if possible? If that fails we can merge this revert. |
Member
|
I'll canary current master once I'm back in Seattle (mid morning) |
Member
Author
|
Looks like canary is working OK so will just close this out and we can roll forward from here with additional fixes. |
Member
|
Yes, not seeing any crashes up until now. |
jpsim
pushed a commit
that referenced
this pull request
Nov 28, 2022
Signed-off-by: Rafal Augustyniak <raugusDescription: Bump versions of test dependencies. Risk Level: Low, tests only. Testing: CI Docs Changes: N/A Release Notes: N/A Signed-off-by: Rafal Augustyniak <raugustyniak@lyft.com>tyniak@lyft.com> Signed-off-by: Rafal Augustyniak <raugustyniak@lyft.com> Signed-off-by: JP Simard <jp@jpsim.com>
jpsim
pushed a commit
that referenced
this pull request
Nov 29, 2022
Signed-off-by: Rafal Augustyniak <raugusDescription: Bump versions of test dependencies. Risk Level: Low, tests only. Testing: CI Docs Changes: N/A Release Notes: N/A Signed-off-by: Rafal Augustyniak <raugustyniak@lyft.com>tyniak@lyft.com> Signed-off-by: Rafal Augustyniak <raugustyniak@lyft.com> Signed-off-by: JP Simard <jp@jpsim.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reverts both #2560 and #2497. I've been chatting with @alyssawilk offline and there are still issues here that need investigation. We think it's better to revert for now.