Skip to content

fix push hook to use the new bazel-y check format call #29458

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
phlax merged 2 commits into from
Sep 7, 2023
+1 −1
Merged

fix push hook to use the new bazel-y check format call #29458

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3c9317f
fix push hook to use the new bazel-y check format call
jbohanon Sep 6, 2023
1cd82f3
|| exit 1
jbohanon Sep 6, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion support/hooks/pre-push
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,7 +72,7 @@ do
# either of these things aren't true, the check fails.
for i in $(git diff --name-only "$RANGE" --diff-filter=ACMR --ignore-submodules=all 2>&1); do
echo -ne " Checking format for $i - "
"$SCRIPT_DIR"/code_format/check_format.py check "$i" || exit 1
bazel run //tools/code_format:check_format -- check "$i" || exit 1

# TODO(phlax): It seems this is not running in CI anymore and is now finding issues
# in merged PRs. Unify this hook and format checks in CI when the new format tool is rolled
Expand Down