Skip to content

fix push hook to use the new bazel-y check format call#29458

Merged
phlax merged 2 commits intoenvoyproxy:mainfrom
jbohanon:git-push-hook-format-check
Sep 7, 2023
Merged

fix push hook to use the new bazel-y check format call#29458
phlax merged 2 commits intoenvoyproxy:mainfrom
jbohanon:git-push-hook-format-check

Conversation

@jbohanon
Copy link
Copy Markdown
Contributor

@jbohanon jbohanon commented Sep 6, 2023

Commit Message:
Additional Description: The changes in #29397 broke the pre-push hook. This changes that hook to use the new bazel target
Risk Level:
Testing:
Docs Changes:
Release Notes:
Platform Specific Features:
[Optional Runtime guard:]
[Optional Fixes #Issue]
[Optional Fixes commit #PR or SHA]
[Optional Deprecated:]
[Optional API Considerations:]

Signed-off-by: Jacob Bohanon <jacob.bohanon@solo.io>
Signed-off-by: Jacob Bohanon <jacob.bohanon@solo.io>
@jbohanon
Copy link
Copy Markdown
Contributor Author

jbohanon commented Sep 7, 2023

cc @phlax

Copy link
Copy Markdown
Member

@phlax phlax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great! thanks for this, @jbohanon, lgtm

@phlax phlax merged commit 6652950 into envoyproxy:main Sep 7, 2023
phlax pushed a commit to phlax/envoy that referenced this pull request Sep 19, 2023
)

Signed-off-by: Jacob Bohanon <jacob.bohanon@solo.io>
Signed-off-by: Ryan Northey <ryan@synca.io>
phlax pushed a commit to phlax/envoy that referenced this pull request Sep 19, 2023
)

Signed-off-by: Jacob Bohanon <jacob.bohanon@solo.io>
Signed-off-by: Ryan Northey <ryan@synca.io>
phlax pushed a commit that referenced this pull request Sep 20, 2023
Signed-off-by: Jacob Bohanon <jacob.bohanon@solo.io>
Signed-off-by: Ryan Northey <ryan@synca.io>
phlax pushed a commit that referenced this pull request Sep 21, 2023
Signed-off-by: Jacob Bohanon <jacob.bohanon@solo.io>
Signed-off-by: Ryan Northey <ryan@synca.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants