ci/format: Bazelify check_format script#29397
Conversation
phlax
changed the title
phlax
force-pushed
the
format-bazel
branch
2 times, most recently
from
1040368 to
c6fccc0
Compare
repokitteh-read-only
Bot
added
the
deps
|
CC @envoyproxy/dependency-shepherds: Your approval is needed for changes made to |
phlax
force-pushed
the
format-bazel
branch
12 times, most recently
from
28c4cf1 to
5a7c2e7
Compare
phlax
changed the title
phlax
changed the title
check_format script
phlax
requested review from
RyanTheOptimist,
abeyad and
alyssawilk
as code owners
phlax
force-pushed
the
format-bazel
branch
2 times, most recently
from
3e16e45 to
c595c3b
Compare
phlax
force-pushed
the
format-bazel
branch
2 times, most recently
from
e3c19e6 to
0589928
Compare
There was a problem hiding this comment.
cc @moderation this was pinned to this version on the basis that this is what we currently use an my initial testing suggested that a version change might create a flood of linting changes (not 100% but thought it better to separate that update - #29405 - unfortunately github is borked atm so hard to test)
There was a problem hiding this comment.
ci is ~working again and confirmed that upgrading brings a load of change
Signed-off-by: Ryan Northey <ryan@synca.io>
|
/retest |
RyanTheOptimist
left a comment
RyanTheOptimist
left a comment
There was a problem hiding this comment.
With this change will people still run ./ci/run_envoy_docker.sh './ci/do_ci.sh check_format' in order to fix the format for Envoy and ./tools/check_format.sh fix to fix the format for Envoy Mobile? If not, we presumably need to announce this change to developers?
yes
this command has been updated to ... $ bazel run //tools/code_format:check_format -- fix ...
im happy to shout out on the dev channel when it lands |
repokitteh-read-only
Bot
removed
the
deps
Thanks, that'd be great! |
| ./library/common/extensions ./test/java ./test/kotlin ./test/objective-c | ||
| ./test/swift ./experimental/swift) | ||
|
|
||
| ENVOY_BAZEL_PREFIX=@envoy ../tools/code_format/check_format.py "${FORMAT_ARGS[@]}" |
There was a problem hiding this comment.
Removing this breaks the script when not run from CI.
Signed-off-by: Joao Grassi <joao.grassi@dynatrace.com>
Signed-off-by: Ryan Northey <ryan@synca.io>
Signed-off-by: Ryan Northey <ryan@synca.io>
Signed-off-by: Ryan Northey <ryan@synca.io>
Signed-off-by: Ryan Northey <ryan@synca.io>
Turns out our file format checkers stopped working some time ago (likely when the `--path` argument was added here: envoyproxy/envoy#29397). Once the path was set, the formatting tools executed, but they were checking format of Envoy files instead of Nighthawk files. Most formatting changes were done automatically except: - addition of missing Python docstrings. - replacement of references to `google::protobuf` by references to the `Envoy::Protobuf` namespace. Fixes #815 Signed-off-by: Jakub Sobon <mumak@google.com>
3 participants
Commit Message:
Additional Description:
Risk Level:
Testing:
Docs Changes:
Release Notes:
Platform Specific Features:
[Optional Runtime guard:]
[Optional Fixes #Issue]
[Optional Fixes commit #PR or SHA]
[Optional Deprecated:]
[Optional API Considerations:]