Skip to content

Update Envoy to 0546512 (Sep 06, 2023)#1018

Merged
eric846 merged 6 commits intoenvoyproxy:mainfrom
eric846:envoy-update-1694026039
Sep 7, 2023
Merged

Update Envoy to 0546512 (Sep 06, 2023)#1018
eric846 merged 6 commits intoenvoyproxy:mainfrom
eric846:envoy-update-1694026039

Conversation

@eric846
Copy link
Copy Markdown
Contributor

@eric846 eric846 commented Sep 6, 2023

  • Updated .bazelrc
  • Updated .bazelversion
  • Updated ci/run_envoy_docker.sh
  • Adapted to the deletion of SingletonLoader in envoyproxy/envoy@a96e0f0. Now we just create a Loader and control its lifetime as a unique_ptr field in the Nighthawk Process object, of which only one should exist at a time.
  • Regenerated Test Server docs (capitalization and punctuation changes only)
  • Adopted the new Bazelified format check (ci/format: Bazelify check_format script envoy#29397): bazel run //tools/code_format:check_format.py changed to bazel run //tools/code_format:check_format
  • Decreased RPS 2x in built-in benchmark suite to deflake the CI. It previously failed 2 out of 3 times on this PR.

Signed-off-by: eric846 <56563761+eric846@users.noreply.github.com>
Signed-off-by: eric846 <56563761+eric846@users.noreply.github.com>
Signed-off-by: eric846 <56563761+eric846@users.noreply.github.com>
Signed-off-by: eric846 <56563761+eric846@users.noreply.github.com>
@eric846
Copy link
Copy Markdown
Contributor Author

eric846 commented Sep 7, 2023

/retest

2 similar comments
@eric846
Copy link
Copy Markdown
Contributor Author

eric846 commented Sep 7, 2023

/retest

@eric846
Copy link
Copy Markdown
Contributor Author

eric846 commented Sep 7, 2023

/retest

@eric846 eric846 marked this pull request as ready for review September 7, 2023 03:53
@eric846
Copy link
Copy Markdown
Contributor Author

eric846 commented Sep 7, 2023

Noting that I had to rerun the CI twice before the benchmark passed.

@eric846 eric846 added the waiting-for-review A PR waiting for a review. label Sep 7, 2023
Signed-off-by: eric846 <56563761+eric846@users.noreply.github.com>
Signed-off-by: eric846 <56563761+eric846@users.noreply.github.com>
@mum4k mum4k requested a review from qqustc September 7, 2023 16:39
@mum4k mum4k removed their assignment Sep 7, 2023
@mum4k
Copy link
Copy Markdown
Collaborator

mum4k commented Sep 7, 2023

@qqustc please review and assign to @eric846 once done.

@qqustc qqustc assigned qqustc and eric846 and unassigned qqustc Sep 7, 2023
@eric846 eric846 merged commit ab17cd4 into envoyproxy:main Sep 7, 2023
@eric846 eric846 removed the waiting-for-review A PR waiting for a review. label Sep 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants