docs: Update instructions for running the code format tool#29596
docs: Update instructions for running the code format tool#29596phlax merged 3 commits intoenvoyproxy:mainfrom
Conversation
Signed-off-by: Joao Grassi <joao.grassi@dynatrace.com>
|
Docs for this Pull Request will be rendered here: https://storage.googleapis.com/envoy-pr/29596/docs/index.html The docs are (re-)rendered each time the CI |
|
Hi @joaopgrassi, welcome and thank you for your contribution. We will try to review your Pull Request as quickly as possible. In the meantime, please take a look at the contribution guidelines if you have not done so already. |
|
small formatting issue - you can fish the diff out of artifacts to fix - https://dev.azure.com/cncf/envoy/_build/results?buildId=149074&view=artifacts&pathAsName=false&type=publishedArtifacts |
| ``` | ||
| ./tools/code_format/check_format.py fix && ./tools/code_format/format_python_tools.sh fix | ||
| ```shell | ||
| bazel run //tools/code_format:check_format -- fix && ./tools/code_format/format_python_tools.sh fix |
There was a problem hiding this comment.
for ref - it the python formatter mentioned here that we need to excise
Signed-off-by: Joao Grassi <joao.grassi@dynatrace.com>
phlax
left a comment
phlax
left a comment
There was a problem hiding this comment.
couple of optional nits and ci formatting issue but otherwise lgtm
Signed-off-by: Joao Grassi <joao.grassi@dynatrace.com>
phlax
left a comment
phlax
left a comment
There was a problem hiding this comment.
thanks for following up @joaopgrassi - appreciated - lgtm
2 participants
Commit Message: Update instructions for running the code format tool
Additional Description: #29397 changed the way to run the
check_formatpython script but the some of the docs are still referring to the "old" way of running it, which does not work anymore.Risk Level:
Testing:
Docs Changes:
Release Notes:
Platform Specific Features:
[Optional Runtime guard:]
[Optional Fixes #Issue]
[Optional Fixes commit #PR or SHA]
[Optional Deprecated:]
[Optional API Considerations:]