Skip to content

Re-enable format checking and reformat all files with findings.#1031

Merged
mum4k merged 24 commits intoenvoyproxy:mainfrom
mum4k:bisect
Oct 27, 2023
Merged

Re-enable format checking and reformat all files with findings.#1031
mum4k merged 24 commits intoenvoyproxy:mainfrom
mum4k:bisect

Conversation

@mum4k
Copy link
Copy Markdown
Collaborator

@mum4k mum4k commented Oct 20, 2023 •
edited
Loading

Turns out our file format checkers stopped working some time ago (likely when the --path argument was added here: envoyproxy/envoy#29397). Once the path was set, the formatting tools executed, but they were checking format of Envoy files instead of Nighthawk files.

Most formatting changes were done automatically except:

  • addition of missing Python docstrings.
  • replacement of references to google::protobuf by references to the Envoy::Protobuf namespace.

Fixes #815

mum4k added 5 commits October 20, 2023 22:22
@mum4k
WIP: bisecting virtualenv issue.
92ee5f8 
Signed-off-by: Jakub Sobon <mumak@google.com>
@mum4k
Latest docker image.
4a8543e 
Signed-off-by: Jakub Sobon <mumak@google.com>
@mum4k
Run outside of Docker.
e7988d7 
Signed-off-by: Jakub Sobon <mumak@google.com>
@mum4k
Revert "Run outside of Docker."
10bf5b9 
This reverts commit 752f943.

Signed-off-by: Jakub Sobon <mumak@google.com>
@mum4k
Exclude check_envoy_includes.py.
a19b0b3 
Signed-off-by: Jakub Sobon <mumak@google.com>
mum4k added 3 commits October 21, 2023 06:29
@mum4k
Fix scripts that chek format.
f1e3bc8 
Signed-off-by: Jakub Sobon <mumak@google.com>
@mum4k
Re-enable check_format.
7164038 
Signed-off-by: Jakub Sobon <mumak@google.com>
@mum4k
Format all files.
61b5918 
Signed-off-by: Jakub Sobon <mumak@google.com>
@mum4k mum4k changed the title WIP: bisecting virtualenv issue. Fix file format checking and reformat all all files with findings. Oct 21, 2023
mum4k added 7 commits October 21, 2023 08:17
@mum4k
Self-review.
7490b41 
Signed-off-by: Jakub Sobon <mumak@google.com>
@mum4k
Add setuptools package.
ef043e6 
Signed-off-by: Jakub Sobon <mumak@google.com>
@mum4k
Install distutils.
a456ae8 
Signed-off-by: Jakub Sobon <mumak@google.com>
@mum4k
Remove package installation.
bceaac9 
Signed-off-by: Jakub Sobon <mumak@google.com>
@mum4k
Back to the old Docker image.
18f3053 
Signed-off-by: Jakub Sobon <mumak@google.com>
@mum4k
Revert pipeline changes.
806fe42 
Signed-off-by: Jakub Sobon <mumak@google.com>
@mum4k
Remove setuptools.
8100d9e 
Signed-off-by: Jakub Sobon <mumak@google.com>
@mum4k mum4k changed the title Fix file format checking and reformat all all files with findings. Fix file format checking and reformat all files with findings. Oct 21, 2023
mum4k added 7 commits October 24, 2023 18:43
@mum4k
Merge branch 'main' into bisect
4c7ce14
@mum4k
Switch to hermetic Python.
b4b149e 
Signed-off-by: Jakub Sobon <mumak@google.com>
@mum4k
Unlocking the Docker image.
3aaee55 
Signed-off-by: Jakub Sobon <mumak@google.com>
@mum4k
Fixing imports of TextFormat.
7a4ba33 
Signed-off-by: Jakub Sobon <mumak@google.com>
@mum4k
Remove clang-tidy from CI.
b1d72a4 
Signed-off-by: Jakub Sobon <mumak@google.com>
@mum4k
Merge branch 'main' into bisect
d598f03
@mum4k
Make the formatting chwck mandatory again.
5641a2d 
Signed-off-by: Jakub Sobon <mumak@google.com>
@mum4k mum4k changed the title Fix file format checking and reformat all files with findings. Re-enable format checking and reformat all files with findings. Oct 26, 2023
@mum4k
We don't want to delete this file in this PR.
abdc5c8 
Signed-off-by: Jakub Sobon <mumak@google.com>
@mum4k mum4k marked this pull request as ready for review October 26, 2023 20:17
@mum4k mum4k requested a review from chipmunkie October 27, 2023 13:13
chipmunkie
chipmunkie reviewed Oct 27, 2023
View reviewed changes
Comment thread include/nighthawk/adaptive_load/input_variable_setter.h
chipmunkie
chipmunkie reviewed Oct 27, 2023
View reviewed changes
Comment thread include/nighthawk/adaptive_load/metrics_plugin.h
chipmunkie
chipmunkie reviewed Oct 27, 2023
View reviewed changes
Comment thread include/nighthawk/adaptive_load/step_controller.h Outdated
chipmunkie
chipmunkie reviewed Oct 27, 2023
View reviewed changes
Comment thread source/adaptive_load/scoring_function_impl.h Outdated
chipmunkie
chipmunkie reviewed Oct 27, 2023
View reviewed changes
Comment thread source/client/flush_worker_impl.h Outdated
chipmunkie
chipmunkie reviewed Oct 27, 2023
View reviewed changes
Comment thread source/request_source/request_options_list_plugin_impl.h Outdated
chipmunkie
chipmunkie reviewed Oct 27, 2023
View reviewed changes
Copy link
Copy Markdown
Contributor

@chipmunkie chipmunkie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I only found a few nits.

Comment thread test/request_source/stub_plugin_impl.h Outdated
@mum4k
Removed duplicate "#pragma once" entries.
78338dc 
Signed-off-by: Jakub Sobon <mumak@google.com>
chipmunkie
chipmunkie approved these changes Oct 27, 2023
View reviewed changes
Copy link
Copy Markdown
Contributor

@chipmunkie chipmunkie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mum4k mum4k merged commit 81a8851 into envoyproxy:main Oct 27, 2023
@mum4k mum4k deleted the bisect branch October 27, 2023 17:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@chipmunkie chipmunkie chipmunkie approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Improve Nighthawk's check_format.py

2 participants

@mum4k @chipmunkie