options: splitting into base class and command line parsing#30924
options: splitting into base class and command line parsing#30924alyssawilk merged 15 commits intoenvoyproxy:mainfrom
Conversation
alyssawilk
force-pushed
the
tclap
branch
4 times, most recently
from
e9417f4 to
da4bd51
Compare
Signed-off-by: Alyssa Wilk <alyssar@chromium.org>
|
This is simply a code split with the exception of the new absl:::Status setLogLevel(absl::string_view) wrapper to avoid a bunch of boilerplate in E-M |
wbpcode
left a comment
wbpcode
left a comment
There was a problem hiding this comment.
Thanks for doing this and two comments are added.
If I got it correctly, this PR split previous OptionsImpl to OptionsImplBase to store all bootstrap options and new OptionsImpl to parse command line by the TCLAP. And and parsing part is unnecessary for the E-M, so we can use OptionsImplBase only in the E-M.
|
And please check the CI, thanks. /wait |
alyssawilk
left a comment
alyssawilk
left a comment
There was a problem hiding this comment.
correct about the split. CI looks weird - a bunch of jobs randomly canceled. retesting but lmk if you want any changes!
Signed-off-by: Alyssa Wilk <alyssar@chromium.org>
|
oops there were 2 build fails buried in the cancels. on it! |
Signed-off-by: Alyssa Wilk <alyssar@chromium.org>
Signed-off-by: Alyssa Wilk <alyssar@chromium.org>
|
oh, seems I cannot stamp it today before I go to 🛏️. CI still say no. |
|
/retest |
|
Azure Pipelines / envoy-presubmit (Linux x64 Build and test) |
Signed-off-by: Alyssa Wilk <alyssar@chromium.org>
Signed-off-by: Alyssa Wilk <alyssar@chromium.org>
|
ugh I have no idea what's with the coverage failure and can't repro locally. I'll ping when this is ready for review. |
|
🤣 Add waiting label first. |
Signed-off-by: Alyssa Wilk <alyssar@chromium.org>
Signed-off-by: Alyssa Wilk <alyssar@chromium.org>
|
/wait |
|
/retest |
|
FINALLY GREEN |
- updated envoy commit number to - updated nighthawk common lib dependency: replace `envoy_common_lib_with_external_headers` with `main_common_lib_with_external_headers` due to change envoyproxy/envoy#30924 Signed-off-by: fei-deng <feid@google.com>
- change `context.runtime()` to `context.serverFactoryContext().runtime()` in source/server/http_dynamic_delay_filter_config.cc due to envoyproxy/envoy#31189 and implemented PANIC methods in NighthawkServerFactoryContext - replace `@envoy//source/exe:envoy_common_lib_with_external_headers` with `@envoy//source/exe:all_extensions_lib_with_external_headers` due to envoyproxy/envoy#31109 - replace `@envoy//source/exe:main_common_lib_with_external_headers` with `@envoy//source/exe:main_common_with_all_extensions_lib_with_external_headers` due to a combination of envoyproxy/envoy#30924 and envoyproxy/envoy#31109 causing unit test `UtilityAddressResolutionTest, AddressResolution` failed because `envoy.network.dns_resolver.cares` was not linked in - lower `upstream_cx_rx_bytes_total` counter threshold in `test_http_h2` integration test. - disable oghttp2 in Nighthawk which was enabled by default in Envoy in envoyproxy/envoy@b58d312 - sync files Signed-off-by: Qin Qin <qqin@google.com>
2 participants
This allows removing the tclap dep from Envoy Mobile.
Risk Level: low
Testing: n/a
Docs Changes: n/a
Release Notes: n/a